Skip to content

Conversation

NicoHinderling
Copy link
Contributor

vanity improvement :P

To match convention so our arroyo consumer metrics use the same metric name as the others

@NicoHinderling NicoHinderling force-pushed the fix-consumer-metric-naming branch from 0feee17 to ea9b131 Compare October 9, 2025 18:35
Copy link
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.78%. Comparing base (080325c) to head (ea9b131).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/launchpad/utils/arroyo_metrics.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files         147      147           
  Lines       11845    11845           
  Branches     1207     1207           
=======================================
  Hits         9451     9451           
  Misses       1960     1960           
  Partials      434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NicoHinderling NicoHinderling merged commit 47dbd23 into main Oct 9, 2025
21 checks passed
@NicoHinderling NicoHinderling deleted the fix-consumer-metric-naming branch October 9, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants