Skip to content

Conversation

SteppingHat
Copy link
Contributor

@SteppingHat SteppingHat commented Sep 23, 2025

This PR includes a fix for running Sentry behind a proxy #3958 where the health check for the seaweedfs container is routed through the proxy due to wget not respecting the no_proxy header.

This issue was seen earlier with the clickhouse container, and this fix mimics the solution used to resolve the issue.

By appending the health check command with http_proxy='', requests to the seaweedfs endpoints are no longer routed through the proxy, allowing the Sentry stack to be installed behind a proxy as this caused the health check to fail otherwise, preventing the stack from being installed.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

# this wget does not support no_proxy. See:
# https://github.com/getsentry/self-hosted/issues/1537
# https://github.com/getsentry/self-hosted/issues/3958
"http_proxy='' wget http://seaweedfs:8080/healthz http://seaweedfs:9333/cluster/healthz http://seaweedfs:8333/healthz || exit 1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious on why you dropped -q -O-. But overall, looks solid!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy paste from my env which I dropped for testing. I seem to have forgotten to put it back, but thanks for pointing it out! I'll put it back in

@aldy505 aldy505 linked an issue Sep 23, 2025 that may be closed by this pull request
1 task
@aldy505
Copy link
Collaborator

aldy505 commented Sep 23, 2025

Integration test error:

  container sentry-self-hosted-seaweedfs-1 is unhealthy
  Error in install/bootstrap-s3-nodestore.sh:3.
  '$dc up --wait seaweedfs postgres' exited with status 1
  yes: standard output: Broken pipe
  yes: standard output: Broken pipe
  -> ./install.sh:main:39
  --> install/bootstrap-s3-nodestore.sh:source:3
  

I assume wrong healthcheck command?

@SteppingHat
Copy link
Contributor Author

@aldy505 probably was due to the related comment with the missing -q -O-. I checked out in a separate repo, applied the change and built the stack and all seems to be good, the tests should pass this time round.

@aldy505
Copy link
Collaborator

aldy505 commented Sep 24, 2025

@aldy505 probably was due to the related comment with the missing -q -O-. I checked out in a separate repo, applied the change and built the stack and all seems to be good, the tests should pass this time round.

Okay. Just approved the CI run, let's see.

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@BYK BYK enabled auto-merge (squash) September 24, 2025 23:43
@BYK
Copy link
Member

BYK commented Sep 24, 2025

There's an incident going on with Docker Hub which is the cause of all these failures: https://www.dockerstatus.com/pages/incident/533c6539221ae15e3f000031/68d47a2f93c09e05486d93a9

Will retry once that's fixed.

@SteppingHat
Copy link
Contributor Author

There's an incident going on with Docker Hub which is the cause of all these failures: https://www.dockerstatus.com/pages/incident/533c6539221ae15e3f000031/68d47a2f93c09e05486d93a9

Will retry once that's fixed.

Looks like it's resolved 😄

@BYK BYK merged commit 1640300 into getsentry:master Sep 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot install or run sentry with seaweedfs behind a proxy
4 participants