-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Unset the proxy when performing the seaweedfs health check #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docker-compose.yml
Outdated
# this wget does not support no_proxy. See: | ||
# https://github.com/getsentry/self-hosted/issues/1537 | ||
# https://github.com/getsentry/self-hosted/issues/3958 | ||
"http_proxy='' wget http://seaweedfs:8080/healthz http://seaweedfs:9333/cluster/healthz http://seaweedfs:8333/healthz || exit 1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious on why you dropped -q -O-
. But overall, looks solid!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a copy paste from my env which I dropped for testing. I seem to have forgotten to put it back, but thanks for pointing it out! I'll put it back in
Integration test error:
I assume wrong healthcheck command? |
@aldy505 probably was due to the related comment with the missing |
Okay. Just approved the CI run, let's see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
There's an incident going on with Docker Hub which is the cause of all these failures: https://www.dockerstatus.com/pages/incident/533c6539221ae15e3f000031/68d47a2f93c09e05486d93a9 Will retry once that's fixed. |
Looks like it's resolved 😄 |
This PR includes a fix for running Sentry behind a proxy #3958 where the health check for the seaweedfs container is routed through the proxy due to wget not respecting the
no_proxy
header.This issue was seen earlier with the clickhouse container, and this fix mimics the solution used to resolve the issue.
By appending the health check command with
http_proxy=''
, requests to the seaweedfs endpoints are no longer routed through the proxy, allowing the Sentry stack to be installed behind a proxy as this caused the health check to fail otherwise, preventing the stack from being installed.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.