-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix swap allocation in integration test #3972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yep, my suspicion was right, latest ubuntu image have less free space, therefore failing.
|
@aminvakil how do we fix it? 😅 |
I'm trying to purge jdk packages right now :) |
@BYK I had another problem in aminvakil/lamp@0d793ff which was breaking mysql installation in docker :) It's fine to remove packages which we do not use in runner image IMO. |
So the issue is we running out of disk space due to swap? |
Removing packages like this is not enough. I'm looking at this repository: https://github.com/endersonmenezes/free-disk-space particularly android section and wonder if I should just copy
or use their action. |
Testing
here: |
https://github.com/aminvakil/docker-tagtest/actions/runs/18038439461/job/51330843317 : The one which really reduces disk usage is |
@aminvakil thx for mention! If you want to use the Action directly on the commit hash, it can improve code maintenance and even eliminate other things you may not need. We're present on Telegram and other large projects, always ethically and trustworthy. Any PRs are also welcome. |
https://github.com/aminvakil/docker-tagtest/actions/runs/18038684596/job/51331642431 : I've tested haskell directory removal here ^ and figured it out the one which really matters is Also This is a better approach than including all of their action, remove more stuff which does not reduce disk space significantly IMHO. @endersonmenezes Thanks for your project! |
Also for future reference: Here is where haskell gets installed on ubuntu runner images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow. Really, wow.
There's also this action I found: https://github.com/marketplace/actions/maximize-build-disk-space That said the main question is: why do we need so much swap space??? |
Interesting! It uses a different approach, although I still like to remove a large directory instead of changing partition layout.
I had a little research (getsentry/sentry-docs#14698) about memory usage of self-hosted. Testing on a clean environment, its memory usage peaked at 28GB. Maybe we can decrease swap size for errors-only profile though. |
I do not know where I'm going with this PR.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.