-
-
Notifications
You must be signed in to change notification settings - Fork 371
[Structured Logging] Add SentryLog Models
#5441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…larations to `SentryLogC.h`, Remove `SentryLog.c`
|
|
I'm not sure regarding naming of the "old" As far as i could tell we use it to print to console, so maybe calling it |
…ntryLogLevel in SentryDefines.h
# Conflicts: # Sentry.xcodeproj/project.pbxproj # Sources/Sentry/SentryHttpTransport.m # Sources/Sentry/SentryNSURLRequest.m # Sources/Sentry/SentryNSURLRequestBuilder.m # Sources/Sentry/SentrySpotlightTransport.m # Tests/SentryTests/Helper/SentryLogSwift.swift # Tests/SentryTests/Helper/SentryLogSwiftTests.swift # Tests/SentryTests/Integrations/SentryBaseIntegrationTests.swift # Tests/SentryTests/SentryCrash/SentryCrashStackCursorSelfThreadTests.swift # Tests/SentryTests/SentrySDKTests.swift
# Conflicts: # Sentry.xcodeproj/project.pbxproj # Sources/Sentry/Profiling/SentryContinuousProfiler.mm # Sources/Sentry/Profiling/SentryTraceProfiler.mm # Sources/Sentry/SentryANRTrackerV1.m # Sources/Sentry/SentryInstallation.m # Sources/Sentry/SentryPerformanceTrackingIntegration.m # Sources/Sentry/SentrySubClassFinder.m # Sources/Sentry/SentryUIApplication.m # Sources/Sentry/SentryViewHierarchyProvider.m # Sources/Swift/Integrations/SessionReplay/SentryOnDemandReplay.swift # Sources/Swift/Integrations/SessionReplay/SentrySessionReplay.swift # Sources/Swift/Integrations/WatchdogTerminations/Processors/SentryWatchdogTerminationContextProcessor.swift # Sources/Swift/Persistence/SentryScopeContextPersistentStore.swift # Tests/SentryTests/Helper/SentrySDKLogTests.swift # Tests/SentryTests/Protocol/Codable/SentryCodableTests.swift
SentryLog Models
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 55f739c | 1226.06 ms | 1248.78 ms | 22.71 ms |
| f97a070 | 1218.88 ms | 1253.12 ms | 34.24 ms |
| acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
| b0e13a7 | 1227.71 ms | 1245.88 ms | 18.16 ms |
| db9572a | 1212.61 ms | 1237.73 ms | 25.13 ms |
| 35c962f | 1207.61 ms | 1235.90 ms | 28.29 ms |
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
| b13e93a | 1236.24 ms | 1247.33 ms | 11.08 ms |
| 8047b99 | 1226.37 ms | 1246.63 ms | 20.26 ms |
| 8ea5293 | 1242.70 ms | 1262.25 ms | 19.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 55f739c | 23.75 KiB | 858.73 KiB | 834.98 KiB |
| f97a070 | 23.75 KiB | 858.68 KiB | 834.93 KiB |
| acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
| b0e13a7 | 23.75 KiB | 860.98 KiB | 837.23 KiB |
| db9572a | 23.75 KiB | 858.65 KiB | 834.90 KiB |
| 35c962f | 23.75 KiB | 854.77 KiB | 831.02 KiB |
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| b13e93a | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 8047b99 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 8ea5293 | 23.75 KiB | 852.24 KiB | 828.49 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I added a few comments.
# Conflicts: # Sentry.xcodeproj/project.pbxproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one open comment (#5441 (comment)) that I have no strong opinion about. Thank you @denrase
|
Thank you @denrase for implementing our feedback 👍 |
This reverts commit 51603df.
This reverts commit 51603df.
#skip-changelog
📜 Description
SentryLog,SentryLog.AttributeandSentryLog.LevelclassesSerialization/Deserialization💡 Motivation and Context
Preparation for structured logs.
Relates to #5122
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.