-
-
Notifications
You must be signed in to change notification settings - Fork 371
ref: Move last round of types to spi #5518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5518 +/- ##
=============================================
+ Coverage 8.307% 86.265% +77.957%
=============================================
Files 371 403 +32
Lines 26903 34912 +8009
Branches 57 15160 +15103
=============================================
+ Hits 2235 30117 +27882
+ Misses 24668 4749 -19919
- Partials 0 46 +46
... and 384 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when CI is green.
cee613c to
4d41df8
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 35c962f | 1207.61 ms | 1235.90 ms | 28.29 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
| 5cfc768 | 1220.74 ms | 1245.06 ms | 24.32 ms |
| 8047b99 | 1226.37 ms | 1246.63 ms | 20.26 ms |
| b13e93a | 1236.24 ms | 1247.33 ms | 11.08 ms |
| db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
| 8ea5293 | 1242.70 ms | 1262.25 ms | 19.55 ms |
| 018037b | 1209.31 ms | 1228.33 ms | 19.03 ms |
| f97a070 | 1218.88 ms | 1253.12 ms | 34.24 ms |
| acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 35c962f | 23.75 KiB | 854.77 KiB | 831.02 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 5cfc768 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 8047b99 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| b13e93a | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
| 8ea5293 | 23.75 KiB | 852.24 KiB | 828.49 KiB |
| 018037b | 23.75 KiB | 867.16 KiB | 843.41 KiB |
| f97a070 | 23.75 KiB | 858.68 KiB | 834.93 KiB |
| acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
This reverts commit 61414e8.
This reverts commit 61414e8.
This should be the last change necessary for #5371 I left removal of the actual build settings until the next PR just to isolate that change, but locally this was all the remaining SPI I needed to get it compiling.
#skip-changelog