Skip to content

Conversation

@noahsmartin
Copy link
Contributor

This should be the last change necessary for #5371 I left removal of the actual build settings until the next PR just to isolate that change, but locally this was all the remaining SPI I needed to get it compiling.

#skip-changelog

@codecov
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.265%. Comparing base (e18d392) to head (2c146ef).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ore/Tools/ViewCapture/SentryViewPhotographer.swift 0.000% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             main     #5518        +/-   ##
=============================================
+ Coverage   8.307%   86.265%   +77.957%     
=============================================
  Files         371       403        +32     
  Lines       26903     34912      +8009     
  Branches       57     15160     +15103     
=============================================
+ Hits         2235     30117     +27882     
+ Misses      24668      4749     -19919     
- Partials        0        46        +46     
Files with missing lines Coverage Δ
SentryTestUtils/TestDisplayLinkWrapper.swift 95.959% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 88.372% <ø> (+46.705%) ⬆️
Sources/Sentry/SentrySessionReplayIntegration.m 89.453% <ø> (+89.453%) ⬆️
...tions/FramesTracking/SentryFramesDelayResult.swift 100.000% <100.000%> (+100.000%) ⬆️
...ssionReplay/RRWeb/SentryRRWebBreadcrumbEvent.swift 100.000% <100.000%> (+100.000%) ⬆️
...ons/SessionReplay/RRWeb/SentryRRWebSpanEvent.swift 100.000% <100.000%> (+100.000%) ⬆️
...egrations/SessionReplay/SentryOnDemandReplay.swift 90.950% <100.000%> (+90.950%) ⬆️
...tegrations/SessionReplay/SentryReplayOptions.swift 100.000% <ø> (+68.750%) ⬆️
...rations/SessionReplay/SentryReplayVideoMaker.swift 100.000% <ø> (+100.000%) ⬆️
...tegrations/SessionReplay/SentrySessionReplay.swift 91.530% <ø> (+91.530%) ⬆️
... and 3 more

... and 384 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18d392...2c146ef. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when CI is green.

@noahsmartin noahsmartin force-pushed the spiFinal branch 2 times, most recently from cee613c to 4d41df8 Compare June 30, 2025 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.88 ms 1239.38 ms 19.51 ms
Size 23.75 KiB 867.69 KiB 843.94 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
35c962f 1207.61 ms 1235.90 ms 28.29 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
8047b99 1226.37 ms 1246.63 ms 20.26 ms
b13e93a 1236.24 ms 1247.33 ms 11.08 ms
db9572a 1200.27 ms 1234.80 ms 34.53 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
018037b 1209.31 ms 1228.33 ms 19.03 ms
f97a070 1218.88 ms 1253.12 ms 34.24 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms

App size

Revision Plain With Sentry Diff
35c962f 23.75 KiB 854.77 KiB 831.02 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
8047b99 23.75 KiB 855.37 KiB 831.62 KiB
b13e93a 23.75 KiB 855.37 KiB 831.62 KiB
db9572a 23.75 KiB 858.69 KiB 834.93 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
018037b 23.75 KiB 867.16 KiB 843.41 KiB
f97a070 23.75 KiB 858.68 KiB 834.93 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB

Previous results on branch: spiFinal

Startup times

Revision Plain With Sentry Diff
1d86d53 1225.21 ms 1248.61 ms 23.40 ms

App size

Revision Plain With Sentry Diff
1d86d53 23.75 KiB 867.68 KiB 843.93 KiB

@noahsmartin noahsmartin merged commit 61414e8 into main Jun 30, 2025
125 checks passed
@noahsmartin noahsmartin deleted the spiFinal branch June 30, 2025 16:33
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants