-
-
Notifications
You must be signed in to change notification settings - Fork 369
fix(session-replay): Extend masking and focus masking on sensitive information #6292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philprime
wants to merge
51
commits into
main
Choose a base branch
from
philprime/fix-masking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,067
−1,127
Open
Changes from 48 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
2942089
fix(session-replay): Ignore list background decoration view in redaction
philprime 648f62d
Merge remote-tracking branch 'origin/main' into philprime/fix-masking
philprime 26dccd1
add comments
philprime ea7ecaa
WIP
philprime edfe055
WIP
philprime 3b84342
WIP
philprime b7e28ef
WIP
philprime 0fc7b14
Merge remote-tracking branch 'origin/main' into philprime/fix-masking
philprime 2adac27
WIP
philprime 5777824
WIP
philprime fa8a6ed
add snapshot tests
philprime 53cff29
Merge remote-tracking branch 'origin/main' into philprime/fix-masking
philprime e180ae3
update tests in common
philprime 1595fb0
fix uiswitch masking
philprime d627f40
cleanup
philprime 8bb64c2
add more assertions to SwiftUI redaction tests
philprime 98c4cb8
Merge remote-tracking branch 'origin/main' into philprime/fix-masking
philprime f0d3b4d
remove legacy screenshot snapshots
philprime 5d5eddb
fix linting issues
philprime 1176dad
revert mask renderer scale 2
philprime c2cc920
regenerate snapshots at 1x
philprime 7c1cd59
add snapshots for SwiftUI masking tests
philprime 3ae9bd4
Merge remote-tracking branch 'origin/main' into philprime/fix-masking
philprime 1ccb38a
WIP
philprime d0aa648
wip
philprime 4e67405
WIP
philprime 8e6ea50
fixes
philprime 00a82e8
remove unstable SwiftUI tests
philprime 4188bfc
remove reference to removed file
philprime 3757102
Merge remote-tracking branch 'origin/main' into philprime/fix-masking
philprime 6f1a29d
remove SwiftUI snapshots
philprime e2e93a8
fix snapshots
philprime 2c93cb9
update changelog
philprime f2e0398
fix compilation for macOS
philprime 05f3e6a
change snapshots to run for iOS 18.4
philprime f70941b
refactor: Change SentryRedactRegion to struct
philprime e533a01
refactor: Rename ExtendedClassIdentifier to ClassIdentifier
philprime f06b0ff
Merge remote-tracking branch 'origin/main' into philprime/fix-masking
philprime 6c6468f
refactor: Remove unnecessary rootView property from multiple test cla…
philprime 0c2bd06
add docs to print view hierarchy
philprime 9ff3a79
WIP
philprime bd97ead
docs: Clarify magic number in shouldRedact method comment
philprime 4015202
Update Sources/Swift/Core/Tools/ViewCapture/SentryUIRedactBuilder.swift
philprime 235d7cb
Enhance SentryUIRedactBuilderTests with manual disposal of fake views…
philprime 184b518
Refactor SentryUIRedactBuilder to use class identifiers as strings
philprime 66f6b1c
Merge branch 'main' into philprime/fix-masking
philprime e60a21f
remove untested screenshots
philprime 26636dd
Introduced optimized lookup structures for redaction classes, allowin…
philprime d8e2690
smaller fixes
philprime 09a1796
fix iOS 26 snapshots
philprime 5a92a94
Merge branch 'main' into philprime/fix-masking
philprime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Sources/Swift/Core/Tools/ViewCapture/SentryRedactRegionType.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.