-
-
Notifications
You must be signed in to change notification settings - Fork 372
Add sentry.replay_id attribute to logs
#6515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
sentry.replay_id to logssentry.replay_id attribute to logs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6515 +/- ##
=============================================
+ Coverage 85.234% 85.464% +0.230%
=============================================
Files 451 451
Lines 27516 27539 +23
Branches 12048 12060 +12
=============================================
+ Hits 23453 23536 +83
+ Misses 4019 3958 -61
- Partials 44 45 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Bug: Replay Headers Cause Compilation IssuesThe |
|
Having some trouble with accessing |
@noahsmartin is good candidate to answer this ⬆️ |
|
I was unsuccessful in exposing |
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once the build issue is fixed
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ed85746 | 1231.79 ms | 1248.55 ms | 16.75 ms |
| 78af7a9 | 1225.75 ms | 1256.98 ms | 31.23 ms |
| e18d392 | 1228.69 ms | 1244.43 ms | 15.73 ms |
| e8da57d | 1203.77 ms | 1234.85 ms | 31.08 ms |
| c5bedc0 | 1203.83 ms | 1236.17 ms | 32.33 ms |
| 52588a5 | 1226.24 ms | 1257.22 ms | 30.98 ms |
| b9ceffb | 1222.57 ms | 1247.96 ms | 25.39 ms |
| caa7e70 | 1233.61 ms | 1259.13 ms | 25.52 ms |
| b5a7583 | 1238.22 ms | 1263.94 ms | 25.71 ms |
| 5c5648e | 1234.44 ms | 1253.79 ms | 19.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ed85746 | 23.75 KiB | 920.83 KiB | 897.08 KiB |
| 78af7a9 | 23.75 KiB | 990.00 KiB | 966.26 KiB |
| e18d392 | 23.75 KiB | 866.68 KiB | 842.93 KiB |
| e8da57d | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| c5bedc0 | 23.75 KiB | 920.63 KiB | 896.89 KiB |
| 52588a5 | 23.75 KiB | 1.00 MiB | 1005.07 KiB |
| b9ceffb | 23.75 KiB | 969.07 KiB | 945.32 KiB |
| caa7e70 | 23.75 KiB | 1004.68 KiB | 980.94 KiB |
| b5a7583 | 23.75 KiB | 913.44 KiB | 889.68 KiB |
| 5c5648e | 23.75 KiB | 879.60 KiB | 855.86 KiB |
Previous results on branch: denrase/replay-id
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb3e0ba | 1219.57 ms | 1261.17 ms | 41.60 ms |
| ba51ef9 | 1231.84 ms | 1263.23 ms | 31.40 ms |
| 03778da | 1218.05 ms | 1246.38 ms | 28.34 ms |
| 680b2c2 | 1221.80 ms | 1247.71 ms | 25.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb3e0ba | 23.75 KiB | 1.02 MiB | 1016.46 KiB |
| ba51ef9 | 23.75 KiB | 1.02 MiB | 1016.45 KiB |
| 03778da | 23.75 KiB | 1.02 MiB | 1016.46 KiB |
| 680b2c2 | 23.75 KiB | 1.00 MiB | 1002.99 KiB |
📜 Description
sentry.replay_idto logs if replay id is set on scopesentry.replay_idandsentry._internal.replay_is_bufferingif replay id is set on integration (buffer mode)💡 Motivation and Context
I tried this with our sample app, but always got no session, and therefore not replayId, from the integration. Was expecting that we have a buffered session, but i'm probably not familiar with how this is implemented on iOS. I assumed the flow is similar to what we have on Android.NVM, this was on iOS 26 where it's disable. Works as expected on iOS < 26.Closes #6133
💚 How did you test it?
Unit tests. Sample app.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.