-
-
Notifications
You must be signed in to change notification settings - Fork 369
Structured Logs: Add captureLog to Hub and Client
#6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@philipphofmann Hacked this together. Works locally. If there are no other blockers, everything should work out without breaking existing public API. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6518 +/- ##
=============================================
+ Coverage 85.899% 86.418% +0.518%
=============================================
Files 451 451
Lines 27482 27494 +12
Branches 11970 11969 -1
=============================================
+ Hits 23607 23760 +153
+ Misses 3826 3691 -135
+ Partials 49 43 -6
... and 50 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
captureLog to Hub and Client
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| afaa522 | 1234.71 ms | 1256.19 ms | 21.48 ms |
| 670b474 | 1225.33 ms | 1259.59 ms | 34.26 ms |
| 162cd7f | 1230.59 ms | 1256.76 ms | 26.16 ms |
| 9add417 | 1224.33 ms | 1243.06 ms | 18.73 ms |
| 4c719e2 | 1206.92 ms | 1237.45 ms | 30.53 ms |
| ac4739e | 1236.55 ms | 1258.89 ms | 22.34 ms |
| 3133d0e | 1237.86 ms | 1262.87 ms | 25.01 ms |
| 51f74d7 | 1236.31 ms | 1247.43 ms | 11.12 ms |
| 85a741b | 1217.02 ms | 1239.27 ms | 22.25 ms |
| 2c59847 | 1216.15 ms | 1253.80 ms | 37.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| afaa522 | 23.74 KiB | 996.91 KiB | 973.17 KiB |
| 670b474 | 23.75 KiB | 974.89 KiB | 951.14 KiB |
| 162cd7f | 23.75 KiB | 908.39 KiB | 884.64 KiB |
| 9add417 | 23.75 KiB | 908.40 KiB | 884.65 KiB |
| 4c719e2 | 23.75 KiB | 912.77 KiB | 889.02 KiB |
| ac4739e | 23.75 KiB | 872.67 KiB | 848.92 KiB |
| 3133d0e | 23.74 KiB | 976.79 KiB | 953.04 KiB |
| 51f74d7 | 23.74 KiB | 874.08 KiB | 850.34 KiB |
| 85a741b | 23.75 KiB | 959.44 KiB | 935.69 KiB |
| 2c59847 | 23.75 KiB | 1.00 MiB | 1005.08 KiB |
📜 Description
captureLogmethods to bothHubandScopeSentryLog, so users can actually create them for hub/client method usage.💡 Motivation and Context
Closes #6503
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.