Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 24, 2025

As title, just removes the V9 checks. The extra line was needed for it to pass unit tests which set the span property.

#skip-changelog

Closes #6527

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.510%. Comparing base (827b50c) to head (5ea1304).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6526       +/-   ##
=============================================
+ Coverage   86.492%   86.510%   +0.018%     
=============================================
  Files          451       451               
  Lines        27488     27488               
  Branches     11970     11971        +1     
=============================================
+ Hits         23775     23780        +5     
+ Misses        3667      3663        -4     
+ Partials        46        45        -1     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827b50c...5ea1304. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.98 ms 1244.76 ms 26.78 ms
Size 23.75 KiB 1.00 MiB 1005.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fb611a9 1222.63 ms 1254.79 ms 32.16 ms
3ec47ae 1231.02 ms 1256.67 ms 25.65 ms
7cc23cf 1203.15 ms 1232.11 ms 28.96 ms
2c889f6 1206.35 ms 1233.29 ms 26.94 ms
2be5991 1228.55 ms 1264.65 ms 36.10 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
9080e6c 1221.17 ms 1247.87 ms 26.71 ms
466e905 1223.78 ms 1256.70 ms 32.92 ms
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
f2bfecd 1234.92 ms 1250.34 ms 15.42 ms

App size

Revision Plain With Sentry Diff
fb611a9 23.74 KiB 1022.38 KiB 998.64 KiB
3ec47ae 23.75 KiB 919.88 KiB 896.13 KiB
7cc23cf 23.75 KiB 913.62 KiB 889.87 KiB
2c889f6 23.75 KiB 1010.42 KiB 986.67 KiB
2be5991 23.75 KiB 994.73 KiB 970.98 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
9080e6c 23.75 KiB 926.80 KiB 903.05 KiB
466e905 23.75 KiB 1010.51 KiB 986.76 KiB
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
f2bfecd 23.75 KiB 919.68 KiB 895.93 KiB

Previous results on branch: scopeSpanReadonlyV9

Startup times

Revision Plain With Sentry Diff
c78f9d8 1223.11 ms 1247.96 ms 24.85 ms

App size

Revision Plain With Sentry Diff
c78f9d8 23.75 KiB 1.00 MiB 1005.07 KiB

@noahsmartin noahsmartin merged commit e5773c1 into main Oct 24, 2025
206 of 219 checks passed
@noahsmartin noahsmartin deleted the scopeSpanReadonlyV9 branch October 24, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Make scope span readonly in V9

2 participants