Skip to content

Conversation

@philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 28, 2025

Updated the expected data count range in the
SentrySpotlightTransportTests to allow for a wider variance in GZip compression results, changing the lower and upper bounds from ±20 to ±40 to avoid flakiness.

Test failed here https://github.com/getsentry/sentry-cocoa/actions/runs/18778698663/job/53579222897.

#skip-changelog

Closes #6550

Updated the expected data count range in the
SentrySpotlightTransportTests to allow for a wider variance in GZip
compression results, changing the lower and upper bounds from ±20 to ±40
to avoid flakiness.
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d14bd20). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6549   +/-   ##
========================================
  Coverage        ?   86.311%           
========================================
  Files           ?       451           
  Lines           ?     37191           
  Branches        ?     17205           
========================================
  Hits            ?     32100           
  Misses          ?      4808           
  Partials        ?       283           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14bd20...42fc4be. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but to be honest this is a wide range and it seems that this test highly unstable. We might want to explore if GZip can be configured to be deterministic

@philipphofmann
Copy link
Member Author

LGTM, but to be honest this is a wide range and it seems that this test highly unstable. We might want to explore if GZip can be configured to be deterministic

True, but honestly, I don't want to invest that time right now for Spotlight. I don't think many people are using it. At least I can't remember a user opening an issue or asking questions about it.

@philipphofmann philipphofmann enabled auto-merge (squash) October 28, 2025 09:17
@philprime
Copy link
Member

I was even thinking about suggesting we remove the tests of Spotlight instead of fixing them.

@philipphofmann
Copy link
Member Author

I was even thinking about suggesting we remove the tests of Spotlight instead of fixing them.

Yes, me too. We can ditch this single test case if it still breaks in the future.

@philipphofmann philipphofmann merged commit 9b3af14 into main Oct 28, 2025
130 of 132 checks passed
@philipphofmann philipphofmann deleted the fix/flaky-spotligh-test branch October 28, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Adjust data count range in SpotlightTests

3 participants