-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix: Multiple attachments support for feedback #6752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 4c86b44.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6752 +/- ##
========================================
Coverage ? 85.613%
========================================
Files ? 453
Lines ? 27692
Branches ? 12147
========================================
Hits ? 23708
Misses ? 3939
Partials ? 45
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ad964ca | 1234.73 ms | 1254.88 ms | 20.15 ms |
| e16fd46 | 1228.64 ms | 1251.57 ms | 22.93 ms |
| c8dd5e4 | 1217.67 ms | 1242.90 ms | 25.23 ms |
| 6d0b605 | 1218.58 ms | 1251.06 ms | 32.48 ms |
| f747c9c | 1237.90 ms | 1264.77 ms | 26.87 ms |
| 2691350 | 1224.92 ms | 1255.82 ms | 30.90 ms |
| fc05805 | 1220.63 ms | 1252.16 ms | 31.54 ms |
| d83b35a | 1212.48 ms | 1237.02 ms | 24.54 ms |
| d157d83 | 1228.02 ms | 1252.47 ms | 24.45 ms |
| 1fecbb8 | 1242.78 ms | 1265.40 ms | 22.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ad964ca | 23.75 KiB | 913.17 KiB | 889.42 KiB |
| e16fd46 | 23.74 KiB | 1.01 MiB | 1008.95 KiB |
| c8dd5e4 | 23.75 KiB | 913.48 KiB | 889.72 KiB |
| 6d0b605 | 23.75 KiB | 1023.82 KiB | 1000.07 KiB |
| f747c9c | 23.75 KiB | 995.60 KiB | 971.85 KiB |
| 2691350 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| fc05805 | 23.75 KiB | 908.02 KiB | 884.27 KiB |
| d83b35a | 23.75 KiB | 913.17 KiB | 889.42 KiB |
| d157d83 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
| 1fecbb8 | 23.75 KiB | 969.28 KiB | 945.53 KiB |
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Updated
SentryFeedbackto accept[Attachment]objects instead of raw[Data]arrays, enabling proper support formultiple attachments with full metadata (filename, content type, etc.).
This also introduces some breaking changes to public API:
initmethod signaturedataDictionary()method now returns attachments as[[String: Any]]with metadata instead of[Data]affecting consumers of theonSubmitSuccesscallbackThis issue originally came up in Unreal SDK while adding attachment support for user feedback:
💡 Motivation and Context
The previous implementation had several limitations:
attachmentsForEnvelope()assumed all attachments were screenshots and hardcoded filename: "screenshot.png" and contentType: "application/png"💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #6753