Skip to content

Conversation

jasonloeve
Copy link

Updating docs to avoid build errors

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Current documentation isn't accurate, fails on build due to using legacy methods, I've added Sentry instructions to a vanilla hydrogen 2025.5 build.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.

  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Updating docs to avoid build errors
Copy link

vercel bot commented Sep 15, 2025

@jasonloeve is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@jasonloeve
Copy link
Author

@onurtemizkan thought i would tag you in this.

@sfanahata
Copy link
Contributor

@AbhiPrasad thoughts on this proposed change?

Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Sep 16, 2025 7:01pm
sentry-docs Ready Ready Preview Comment Sep 16, 2025 7:01pm

@AbhiPrasad
Copy link
Member

@onurtemizkan could you help test these changes out?

@jasonloeve
Copy link
Author

@onurtemizkan could you help test these changes out?

I think there may be further issues with this documentation, it seems sourcemap uploading doesnt work via sentryReactRouter but does working when installing @sentry/vite-plugin and using sentryVitePlugin in the vite config and setting up a slightly different way

@jasonloeve
Copy link
Author

Also having to install using flag --legacy-peer-deps due to dependency errors isnt the greatest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants