fix(docs): Add ProGuard related properties to MAUI MSBuild page #14995
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 9.13kB (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
…maui-msbuild-page
| Controls uploading ProGuard mapping file to Sentry after the build. Defaults to `false` (disabled). | ||
|
|
||
| Set to `true` to upload ProGuard mapping file to Sentry. | ||
| Your resulting APK will be injected with the metadata `io.sentry.proguard-uuid`. `AndroidManifest.xml` will contain a metadata entry such as the following: |
There was a problem hiding this comment.
I wasn't quite sure, reading this, what happens if I set it to true.
I think (correct me if I'm wrong) when this is set to true, a ProGuard mapping file is uploaded to Sentry after the build (and the mapping file contains the GUID from the AndroidManifest.xml right)?
Isn't injecting the GUID into the APK controlled separately by the SentryProGuardUUID build property (or doesn't automatically if that property isn't set)?
There was a problem hiding this comment.
I agree the phrasing is quite bad here.
Yes, the mapping file will be associated with the GUID from the AndroidManifest.xml, though I don't think the mapping file "contains" the GUID, it is just named with the GUID:
We do inject the GUID into the APK separately, and it's controlled by SentryProguardUUID (user-defined or generated during build-time).
I think I'll just rephrase this, and maybe get rid of that xml code snippet because it may be even more confusing to those who are not interested in the inner-workings.
Co-authored-by: James Crosswell <[email protected]>
Co-authored-by: James Crosswell <[email protected]>
|
@jamescrosswell I'd say we hold off on merging this until we release the ProGuard related changes. Thoughts? |
Yes although it looks like those have already been merged. Let me know if/when you want me to take another look at this. |
|
@jamescrosswell Yes, please review again! |
alexsohn1126
deleted the
alexsohn/fix/add-proguard-related-info-to-maui-msbuild-page
branch
DESCRIBE YOUR PR
Adds more information about Proguard mapping file upload feature we have in .NET MAUI app.
Should be merged after this change is merged:
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES