-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(fix): Update Issues > Feature Flag docs To Clarify Feature Flag Change Tracking #14996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 5.27kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jas-kas i think flag events can also be shown on the chart if they are after the event as well. as long as it's associated with the audit log (change tracking), the flag has the possibility of showing up

cc @cmanallen |
@michellewzhang What I meant was the feature flag changes that we end up showing on the event volume chart are ones that were part of the evaluation tracking list to begin with (i.e., flags evaluated before an error event in the issue that are shown in the table view on an Issue Details and also part of the feature flag drawer). We did this as a way to filter the FF change annotations to be less noisy and show more relevant flags |
wait then why am i seeing lines after the error event happened ![]() |
 | ||
|
||
Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line. | ||
Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line. The lines will only appear for flags that were evaluated before the error event occurred. This feature requires evaluation tracking to be enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line. The lines will only appear for flags that were evaluated before the error event occurred. This feature requires evaluation tracking to be enabled. | |
Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line. The lines will only appear for flags that were evaluated before the error event occurred. This feature requires evaluation tracking to be enabled. |
makes sense to me now, but maybe we want to add a note here that we might still show flag changes after the error event to make the difference clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, updated!
I think we should show flags regardless of if its before or after the event so long as they're related. It might show that toggling the flag off stopped the errors. That would be an interesting finding on it owns. |
Yes, exactly! As long as the flag is related to the errors in an issue, the feature flag definition changes will display in the event volume chart (and those could be before or after error events in the time-series) |
Co-authored-by: Michelle Zhang <[email protected]>
Update description on feature flag change tracking to make it clear that evaluation tracking needs to be enabled in order to see feature flag change annotations