Skip to content

Conversation

jas-kas
Copy link
Member

@jas-kas jas-kas commented Sep 19, 2025

Update description on feature flag change tracking to make it clear that evaluation tracking needs to be enabled in order to see feature flag change annotations

Copy link

vercel bot commented Sep 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 22, 2025 2:51pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 22, 2025 2:51pm

Copy link

codecov bot commented Sep 19, 2025

Bundle Report

Changes will increase total bundle size by 5.27kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.12MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.85MB 5.28kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 1.76kB 822.61kB 0.21%
../app/platform-redirect/page.js.nft.json 1.76kB 822.52kB 0.21%
../app/sitemap.xml/route.js.nft.json 1.76kB 819.75kB 0.22%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/V_EKoJmHtfPiqGcM3-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/V_EKoJmHtfPiqGcM3-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/HgZIQO2YRTpkzGC4bF3pO/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/HgZIQO2YRTpkzGC4bF3pO/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jas-kas i think flag events can also be shown on the chart if they are after the event as well. as long as it's associated with the audit log (change tracking), the flag has the possibility of showing up

SCR-20250919-ktuw

@michellewzhang
Copy link
Member

@jas-kas i think flag events can also be shown on the chart if they are after the event as well. as long as it's associated with the audit log (change tracking), the flag has the possibility of showing up

SCR-20250919-ktuw

cc @cmanallen

@jas-kas
Copy link
Member Author

jas-kas commented Sep 19, 2025

@michellewzhang What I meant was the feature flag changes that we end up showing on the event volume chart are ones that were part of the evaluation tracking list to begin with (i.e., flags evaluated before an error event in the issue that are shown in the table view on an Issue Details and also part of the feature flag drawer). We did this as a way to filter the FF change annotations to be less noisy and show more relevant flags

@michellewzhang
Copy link
Member

michellewzhang commented Sep 19, 2025

@michellewzhang What I meant was the feature flag changes that we end up showing on the event volume chart are ones that were part of the evaluation tracking list to begin with (i.e., flags evaluated before an error event in the issue that are shown in the table view on an Issue Details and also part of the feature flag drawer). We did this as a way to filter the FF change annotations to be less noisy and show more relevant flags

wait then why am i seeing lines after the error event happened

SCR-20250919-kwaw

![Flag Change Tracking](./img/FlagChangeTracking.png)

Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line.
Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line. The lines will only appear for flags that were evaluated before the error event occurred. This feature requires evaluation tracking to be enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line. The lines will only appear for flags that were evaluated before the error event occurred. This feature requires evaluation tracking to be enabled.
Within an issue, the audit log is represented in the "event" chart and presents itself as a "release" line. The lines will only appear for flags that were evaluated before the error event occurred. This feature requires evaluation tracking to be enabled.

makes sense to me now, but maybe we want to add a note here that we might still show flag changes after the error event to make the difference clear

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, updated!

@cmanallen
Copy link
Member

I think we should show flags regardless of if its before or after the event so long as they're related. It might show that toggling the flag off stopped the errors. That would be an interesting finding on it owns.

@jas-kas
Copy link
Member Author

jas-kas commented Sep 22, 2025

@cmanallen

I think we should show flags regardless of if its before or after the event so long as they're related

Yes, exactly! As long as the flag is related to the errors in an issue, the feature flag definition changes will display in the event volume chart (and those could be before or after error events in the time-series)

@jas-kas jas-kas enabled auto-merge (squash) September 22, 2025 14:18
@jas-kas jas-kas merged commit 2be5af4 into master Sep 22, 2025
13 checks passed
@jas-kas jas-kas deleted the jas-kas-update-ff-docs-1 branch September 22, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants