Skip to content

Conversation

@jaffrepaul
Copy link
Contributor

DESCRIBE YOUR PR

This improves a recent fix (#15473) that was helping keywords render in code blocks. Some worked but further down the page the keyword still hadn't rendered.

Swapped useEffect with useLayoutEffect to set isMounted state more reliably. This ensures keyword interpolation happens synchronously before paint. Also tweaked an animation to help with the pause before keywords render.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Nov 13, 2025 1:14am
sentry-docs Ready Ready Preview Comment Nov 13, 2025 1:14am

@jaffrepaul jaffrepaul requested a review from sergical November 13, 2025 00:59
@codecov
Copy link

codecov bot commented Nov 13, 2025

Bundle Report

Changes will increase total bundle size by 293 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.17MB -31 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.62MB 324 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 130 bytes 769.72kB 0.02%
../app/platform-redirect/page.js.nft.json 130 bytes 769.63kB 0.02%
../app/sitemap.xml/route.js.nft.json 130 bytes 766.86kB 0.02%
../app/[[...path]]/page.js -57 bytes 619.92kB -0.01%

Files in ../app/[[...path]]/page.js:

  • ./src/components/codeBlock/index.tsx → Total Size: 1.3kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] -57 bytes 3.37MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/app/[[...path]]/page-*.js -25 bytes 95.93kB -0.03%
static/F-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/F-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/8JrTHj0ZB3rIBsWL62em4/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/8JrTHj0ZB3rIBsWL62em4/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants