-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(preprod): add watchos section + update code signature #15538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+26
−21
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ac0b81f
code signature
trevor-e 708536f
shorten
trevor-e 4a7410a
add command
trevor-e 0466e1f
Update includes/size-analysis/binary-code-signature.mdx
trevor-e 15a88bb
watch
trevor-e dff77fa
fix
trevor-e 19e756d
Merge branch 'master' into telkins/arch-thinning
trevor-e 507f40c
fix
trevor-e d1d49e2
update
trevor-e 812f33f
fix
trevor-e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| Mach-O binaries contain code signature data within the `LC_CODE_SIGNATURE` load command which itself contains `SHA1` and/or `SHA256` hashes of every page block. This means the size of this data will scale linearly with the size of your binary. | ||
|
|
||
| By default Sentry calculates the size of this data as-is. You may notice differences when comparing against your app downloaded from the App Store. For example, Xcode 26 archives only codesign with `SHA256` hashes, but the App Store codesigns with both `SHA1` and `SHA256` hashes. In other words, App Store downloads of your app may be slightly larger than what's produced by Xcode. This App Store behavior is subject to change at any time. | ||
|
|
||
| If you'd like to compare the impact of this on your app, you can re-sign each binary before uploading to Sentry: | ||
|
|
||
| ```bash | ||
| # Inspect the current code signature | ||
| codesign -dvvv '/path/to/your/binary' | ||
|
|
||
| # Re-sign with a new code signature | ||
| codesign --force \ | ||
| --sign 'Apple Distribution: Your Team (team_id)' \ | ||
| --digest-algorithm sha1 \ | ||
| --digest-algorithm sha256 \ | ||
| '/path/to/your/binary' | ||
| ``` | ||
|
|
||
| This will force both `SHA1` and `SHA256` hashes to be used. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| WatchOS apps produced by Xcode often contain both `arm64_32` and `arm64` architectures in a single fat binary. By default Sentry calculates the size of this data as-is, however, your end users will only download whatever architecture is necessary for their device. It's recommended to apply [App Thinning](/platforms/apple/guides/ios/size-analysis#app-thinning) before uploading for more representative results. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.