-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(otlp): Add develop docs for OTLPIntegration #15548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a2ab569 to
4d873b4
Compare
4d873b4 to
e36f698
Compare
e36f698 to
8fef46f
Compare
b289917 to
c861c3c
Compare
c861c3c to
47e7881
Compare
Bundle ReportChanges will increase total bundle size by 52.59kB (0.22%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
|
47e7881 to
0efe4c0
Compare
| It MUST consist of and setup the following components: | ||
|
|
||
| * A `SpanExporter` that automatically configures the OTLP ingestion endpoint from the DSN | ||
| * A `Propagator` that ensures Distributed Tracing works with other upstream and downstream services using Sentry SDKs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also specify this works by attaching a sentry-trace header, and NOT a traceparent header here?
|
|
||
| ### SpanExporter | ||
|
|
||
| IF `setup_otlp_exporter` is `True`, the integration MUST do the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make this name traces specific?
Because it might also make sense to have one for logs as well.
| IF `setup_otlp_exporter` is `True`, the integration MUST do the following: | ||
|
|
||
| * Take the existing `TracerProvider` from OpenTelemetry if it exists, otherwise create a new one | ||
| * Construct the OTLP Traces `endpoint` from the DSN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Construct the OTLP Traces
endpointfrom the DSN
We should add docs for this.
|
|
||
| * A `SpanProcessor` for processing and packaging the Spans that OpenTelemetry emits | ||
| * A `Propagator` that ensures Distributed Tracing works with other upstream and downstream services using Sentry SDKs | ||
| * A `Sampler` that works with Sentry's `traces_sample_rate` and `traces_sampler` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth leaving an extra note about why we don't need a sampler for this setup anymore.
preview: https://develop-docs-git-neel-otlp-develop.sentry.dev/sdk/telemetry/traces/otlp/
resolves
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: