Skip to content

ci: handle independent go module versions for integrations#1217

Merged
giortzisg merged 2 commits intomasterfrom
ci/independent-go-versions
Mar 3, 2026
Merged

ci: handle independent go module versions for integrations#1217
giortzisg merged 2 commits intomasterfrom
ci/independent-go-versions

Conversation

@giortzisg
Copy link
Contributor

Description

Decouple integration Go versions from the main SDK so each module can require a newer Go version when its upstream dependencies demand it.

All Makefile targets (build, vet, test/%, test-coverage, test-race-coverage) now read each module's go directive and skip modules that require a newer Go than the current toolchain. The mod-tidy target reads each module's go directive instead of hardcoding 1.24.0, so it works correctly for modules with different minimum versions.

CI runs mod-tidy on the most recent go version, to tidy modules that don't require the minimum supported version of the main sdk. No other CI changes needed — the Makefile handles skipping automatically.

As a first use of this, bumps echo/go.mod from go 1.24.0 to go 1.25.0 to prepare for the Echo v5 upgrade (#1183).

Refs #1183

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

@giortzisg giortzisg self-assigned this Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Add the option to set attributes on the scope by giortzisg in #1208

Internal Changes 🔧

Deps

  • Bump getsentry/craft from 2.20.1 to 2.23.1 by dependabot in #1213
  • Bump github.com/gofiber/fiber/v2 from 2.52.11 to 2.52.12 in /fiber by dependabot in #1209

Other

  • (ai) Add dotagents configuration by giortzisg in #1211
  • Handle independent go module versions for integrations by giortzisg in #1217

🤖 This preview updates automatically when you update the PR.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@dingsdax
Copy link
Contributor

dingsdax commented Mar 3, 2026

I was wondering, why is that a Makefile? Is there a reason? Or would something like https://magefile.org/ or a small cmd/build/main.go also work?

@giortzisg
Copy link
Contributor Author

Mostly trying to keep dependencies for the runners to the minimum. I can open another issue for adding an entrypoint and making it more idiomatic.

@giortzisg giortzisg merged commit f68bc0a into master Mar 3, 2026
18 of 19 checks passed
@giortzisg giortzisg deleted the ci/independent-go-versions branch March 3, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants