ci: handle independent go module versions for integrations#1217
Merged
ci: handle independent go module versions for integrations#1217
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
dingsdax
approved these changes
Mar 3, 2026
Contributor
|
I was wondering, why is that a Makefile? Is there a reason? Or would something like https://magefile.org/ or a small cmd/build/main.go also work? |
Contributor
Author
|
Mostly trying to keep dependencies for the runners to the minimum. I can open another issue for adding an entrypoint and making it more idiomatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decouple integration Go versions from the main SDK so each module can require a newer Go version when its upstream dependencies demand it.
All Makefile targets (build, vet, test/%, test-coverage, test-race-coverage) now read each module's go directive and skip modules that require a newer Go than the current toolchain. The mod-tidy target reads each module's go directive instead of hardcoding 1.24.0, so it works correctly for modules with different minimum versions.
CI runs mod-tidy on the most recent go version, to tidy modules that don't require the minimum supported version of the main sdk. No other CI changes needed — the Makefile handles skipping automatically.
As a first use of this, bumps echo/go.mod from go 1.24.0 to go 1.25.0 to prepare for the Echo v5 upgrade (#1183).
Refs #1183
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)