Skip to content

fix: TestAsyncTransport_SendEnvelope flakiness#1226

Merged
giortzisg merged 1 commit intomasterfrom
fix/flaky-queue-overflow
Mar 12, 2026
Merged

fix: TestAsyncTransport_SendEnvelope flakiness#1226
giortzisg merged 1 commit intomasterfrom
fix/flaky-queue-overflow

Conversation

@giortzisg
Copy link
Contributor

Description

The queue overflow testcase was using an unbuffered channel for RequestReceived, to block the worker so that no other events get consumed and the overflow will be guaranteed. The channel however was unbuffered, so the requestReceived (worker) could race with the test and block the main routine till timeout

#skip-changelog

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

The queue overflow testcase was using an unbuffered channel for
RequestReceived, to block the worker so that no other events get
consumed and the overflow will be guaranteed. The channel however was
unbuffered, so the requestReceived (worker) could race with the test and
block the main routine till timeout
@giortzisg giortzisg requested a review from Litarnus March 12, 2026 09:49
@giortzisg giortzisg self-assigned this Mar 12, 2026
@github-actions
Copy link

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@giortzisg giortzisg merged commit 340c142 into master Mar 12, 2026
19 checks passed
@giortzisg giortzisg deleted the fix/flaky-queue-overflow branch March 12, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants