Skip to content

feat(uptime): Add request{method,headers,body} fields #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat(uptime): Add request{method,headers,body} fields #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8291637
feat(uptime): Add request{method,header,body} options
evanpurkhiser Sep 13, 2024
0a71e9c
style(lint): Auto commit lint changes
getsantry[bot] Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/uptime-configs/1/example-post.msgpack
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
‡¯subscription_idÙ d7629c6c82be4f679ee78a0d977856d2£url°http://sentry.io°interval_secondsÍ,ªtimeout_msÍô®request_method¤POST¯request_headersƒ­Authorization¬Bearer 12345¬Content-Type°application/json²X-My-Custom-Header­example value¬request_body°{"key": "value"}
16 changes: 16 additions & 0 deletions schemas/uptime-configs.v1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@
"url": {
"description": "The actual HTTP URL to check.",
"type": "string"
},
"request_method": {
"description": "The HTTP method to use for the request.",
"type": "string",
"enum": ["GET", "POST", "HEAD", "PUT", "DELETE", "PATCH", "OPTIONS"]
},
"request_headers": {
"description": "Additional HTTP headers to send with the request",
"type": "object",
"additionalProperties": {
"type": "string"
}
},
"request_body": {
"description": "Additional HTTP headers to send with the request",
"type": "string"
Comment on lines +45 to +47
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I'm thinking about it... should the body also just be a json dict? Mostly people are sending specific key/val params here right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I think it's very reasonable someone might want to pass xml or some other format

}
},
"required": ["subscription_id", "interval_seconds", "timeout_ms", "url"]
Expand Down
Loading