-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(crons): Add mark_unknown clock task
#340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crons): Add mark_unknown clock task
#340
Conversation
|
versions in use: The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.
latest version: 0.1.113 There were changes to the JSON schema file, but we couldn't categorize any of This might be a gap in linting. Want to take a look at |
32415ac to
1352829
Compare
| { | ||
| "type": "mark_unknown", | ||
| "ts": 1714072962, | ||
| "monitor_environment_id": 1, | ||
| "checkin_id": 1 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that when we detected an outage, we'd just set a variable somewhere so that when we go to mark a miss, we mark an unknown instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we will. This is for marking all in progress as unknown status.
We need to do this when we detect an anomaly during a clock tick since it means there may be OK check-ins that were dropped and we would mark those check-ins as timed out once they reach their timeout_at later (after the volume has returned to normal).
dc45c98 to
914fa19
Compare
This task will be triggered when we detect an anomaly in check-in volume during a clock tick. When this happens we are unable to know that all check-ins before that tick have been received and will need to mark all in-progress monitors as resulting in a 'unknown' state. Part of getsentry/sentry#79328
914fa19 to
d61a7a9
Compare
mark_unknown clock task
This task will be triggered when we detect an anomaly in check-in
volume during a clock tick. When this happens we are unable to know that
all check-ins before that tick have been received and will need to mark
all in-progress monitors as resulting in a 'unknown' state.
Part of getsentry/sentry#79328