Skip to content

Conversation

@evanpurkhiser
Copy link
Member

This task will be triggered when we detect an anomaly in check-in
volume during a clock tick. When this happens we are unable to know that
all check-ins before that tick have been received and will need to mark
all in-progress monitors as resulting in a 'unknown' state.

Part of getsentry/sentry#79328

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 23, 2024 20:18
@github-actions
Copy link

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.111 (upgrade)

latest version: 0.1.113

There were changes to the JSON schema file, but we couldn't categorize any of
them. Therefore we don't know whether this change is safe to make.

This might be a gap in linting. Want to take a look at
https://github.com/getsentry/json-schema-diff/ and figure it out?

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-add-mark-unknown-clock-task branch 2 times, most recently from 32415ac to 1352829 Compare October 23, 2024 21:06
Comment on lines +1 to +6
{
"type": "mark_unknown",
"ts": 1714072962,
"monitor_environment_id": 1,
"checkin_id": 1
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that when we detected an outage, we'd just set a variable somewhere so that when we go to mark a miss, we mark an unknown instead?

Copy link
Member Author

@evanpurkhiser evanpurkhiser Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we will. This is for marking all in progress as unknown status.

We need to do this when we detect an anomaly during a clock tick since it means there may be OK check-ins that were dropped and we would mark those check-ins as timed out once they reach their timeout_at later (after the volume has returned to normal).

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-add-mark-unknown-clock-task branch 2 times, most recently from dc45c98 to 914fa19 Compare October 24, 2024 18:07
This task will be triggered when we detect an anomaly in check-in
volume during a clock tick. When this happens we are unable to know that
all check-ins before that tick have been received and will need to mark
all in-progress monitors as resulting in a 'unknown' state.

Part of getsentry/sentry#79328
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-add-mark-unknown-clock-task branch from 914fa19 to d61a7a9 Compare October 24, 2024 18:09
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) October 24, 2024 21:03
@evanpurkhiser evanpurkhiser changed the title feat(crons): Add mark_unknown clock task feat(crons): Add mark_unknown clock task Oct 24, 2024
@evanpurkhiser evanpurkhiser merged commit 3ff937b into main Oct 25, 2024
16 of 17 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-crons-add-mark-unknown-clock-task branch October 25, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants