Skip to content

Conversation

wedamija
Copy link
Member

To support multi region, each region needs to be aware of other regions and the scheduling mode it's running in.

To support multi region, each region needs to be aware of other regions and the scheduling mode it's running in.
@wedamija wedamija requested a review from a team as a code owner December 17, 2024 22:25
@github-actions
Copy link

github-actions bot commented Dec 17, 2024

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

latest version: 0.1.122

changes considered breaking

schemas/uptime-configs.v1.schema.json

  • Added a new property, but the consumer has been ignoring additional properties so far. This is probably still fine, but please double-check that the producer does not already send this property with a different type in practice than you defined in this schema.

    {"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "active_regions"}}}
    
  • Added a new property, but the consumer has been ignoring additional properties so far. This is probably still fine, but please double-check that the producer does not already send this property with a different type in practice than you defined in this schema.

    {"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "region_schedule_mode"}}}
    

⚠️ This PR contains breaking changes. Normally you should avoid that and make
your consumer backwards-compatible (meaning that updated consumers can still
accept old messages). There are a few exceptions:

  • If consumers already require these invariants in practice, and you're
    just adjusting the JSON schema to reality, ignore this warning.

  • If you know what you are doing, this change could potentially be rolled out
    to producers first, but that's not a flow we support.

@wedamija wedamija enabled auto-merge (squash) December 18, 2024 21:58
@wedamija wedamija disabled auto-merge December 18, 2024 21:58
@wedamija wedamija enabled auto-merge (squash) December 18, 2024 21:59
@wedamija wedamija merged commit 769dd6a into main Dec 18, 2024
15 of 16 checks passed
@wedamija wedamija deleted the danf/uptime-regions branch December 18, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants