-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(spans): Span V2 kafka schema #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
versions in use: The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change. latest version: 2.1.3 changes that might be breaking: schemas/ingest-spans.v1.schema.json
benign changesschemas/buffered-segments.v1.schema.json
schemas/ingest-spans.v1.schema.json
|
| "type": "array", | ||
| "minItems": 1, | ||
| "items": { | ||
| "$ref": "#/definitions/SegmentSpan" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Segment spans and ingest spans have the same format now.
| "properties": { | ||
| "event_id": { | ||
| "$ref": "#/definitions/UUID" | ||
| "$ref": "file://./ingest-spans.v1.schema.json#/definitions/UUID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to use full URLs here to keep the build script & tests happy.
Spans written to Kafka by Relay are now a superset of the Span V2 schema.
See https://linear.app/getsentry/project/align-sentry-span-kafka-schema-with-span-v2-a77fced29f22/overview.
Closes INGEST-540.