Skip to content

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Oct 2, 2025

Turns out the rust schema resolver cannot handle relative paths with a dot, see #360.

Fix relative paths and add a line to rust tests that would have caught this.

ref: INGEST-540

Copy link

github-actions bot commented Oct 2, 2025

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

latest version: 2.1.4

There were changes to the JSON schema file, but we couldn't categorize any of
them. Therefore we don't know whether this change is safe to make.

This might be a gap in linting. Want to take a look at
https://github.com/getsentry/json-schema-diff/ and figure it out?

Copy link

linear bot commented Oct 2, 2025

@jjbayer jjbayer marked this pull request as ready for review October 2, 2025 06:15
@jjbayer jjbayer requested review from a team as code owners October 2, 2025 06:15
@jjbayer jjbayer merged commit cd25006 into main Oct 2, 2025
17 of 18 checks passed
@jjbayer jjbayer deleted the fix/spans-relpaths branch October 2, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants