- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 198
          feat: outgoing traceparent header support
          #1394
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 9 commits
      Commits
    
    
            Show all changes
          
          
            18 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      27247f1
              
                initial traceparent support
              
              
                JoshuaMoelans 3e51545
              
                CHANGELOG.md update
              
              
                JoshuaMoelans 8e1d492
              
                consolidate tests
              
              
                JoshuaMoelans 32b33fd
              
                Merge branch 'master' into joshua/feat/traceparent
              
              
                JoshuaMoelans 707fcc8
              
                remove redundant value_len check
              
              
                JoshuaMoelans 1ee9ef4
              
                check for exact length
              
              
                JoshuaMoelans 8b9a7fa
              
                reuse header key comparison + extract parsing per header type
              
              
                JoshuaMoelans 51c2711
              
                static internal helper
              
              
                JoshuaMoelans c0ea44a
              
                add size bounds + checks for headers
              
              
                JoshuaMoelans 4714c61
              
                only accept 00 or 01 sampling flag
              
              
                JoshuaMoelans 5ee684f
              
                Apply suggestion from @supervacuus
              
              
                JoshuaMoelans e269903
              
                Apply suggestion from @supervacuus
              
              
                JoshuaMoelans 6561f7e
              
                Apply suggestion from @supervacuus
              
              
                JoshuaMoelans 28226e7
              
                Apply suggestion from @supervacuus
              
              
                JoshuaMoelans 3262fa4
              
                fix(traceparent): only support outgoing for now (#1406)
              
              
                JoshuaMoelans fb4ad87
              
                add tests to verify consistency of trace and span IDs across headers …
              
              
                JoshuaMoelans 866e799
              
                use trace header sizes in header propagation
              
              
                JoshuaMoelans 763acd4
              
                update CHANGELOG.md
              
              
                JoshuaMoelans File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
          Some comments aren't visible on the classic Files Changed page.
        
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -42,6 +42,7 @@ struct sentry_options_s { | |
| bool attach_screenshot; | ||
| bool crashpad_wait_for_upload; | ||
| bool enable_logging_when_crashed; | ||
| bool propagate_traceparent; | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One of these days, we should convert all these flags to bitfields. But not in this PR. | ||
|  | ||
| sentry_attachment_t *attachments; | ||
| sentry_run_t *run; | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.