Skip to content

Conversation

antonpirker
Copy link
Contributor

Second part of #4102

@antonpirker antonpirker requested a review from a team as a code owner April 1, 2025 10:54
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (bff8fdd) to head (935c345).
Report is 19 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4223      +/-   ##
==============================================
+ Coverage       83.47%   83.49%   +0.02%     
==============================================
  Files             143      143              
  Lines           14678    14631      -47     
  Branches         2332     2317      -15     
==============================================
- Hits            12252    12216      -36     
+ Misses           1709     1698      -11     
  Partials          717      717              
Files with missing lines Coverage Δ
sentry_sdk/consts.py 99.51% <ø> (ø)
sentry_sdk/tracing.py 79.94% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused by this PR; I am unsure what its purpose is supposed to be.

How does it relate to #4222? Did you mean to have it based on potel-base or master?

@antonpirker antonpirker marked this pull request as draft April 1, 2025 13:29
):
sentry_init(traces_sampler=traces_sampler)
sentry_init(
traces_sample_rate=None,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passes only if traces_sample_rate=None and it fails when it is 0 or 1.0. I am not sure if this is the excepted behavior.

@antonpirker
Copy link
Contributor Author

@antonpirker antonpirker closed this Apr 9, 2025
@antonpirker antonpirker deleted the antonpirker/potel/deprecate-update-certain-apis branch April 22, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants