Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 4, 2025

  • trytond<5, falcon<3, django<2 are all more than 5 years old

Closes #4049

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (445ebc9) to head (56bdf54).
Report is 2 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4246      +/-   ##
==============================================
+ Coverage       83.52%   83.62%   +0.09%     
==============================================
  Files             144      144              
  Lines           14723    14695      -28     
  Branches         2335     2330       -5     
==============================================
- Hits            12298    12288      -10     
+ Misses           1702     1690      -12     
+ Partials          723      717       -6     
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 89.61% <ø> (+2.59%) ⬆️
sentry_sdk/integrations/django/__init__.py 85.02% <100.00%> (+1.37%) ⬆️
sentry_sdk/integrations/django/templates.py 56.70% <100.00%> (+1.36%) ⬆️
sentry_sdk/integrations/django/transactions.py 92.18% <100.00%> (-0.35%) ⬇️
sentry_sdk/integrations/falcon.py 91.30% <100.00%> (-0.57%) ⬇️
sentry_sdk/integrations/trytond.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review April 4, 2025 13:10
@sentrivana sentrivana requested a review from a team as a code owner April 4, 2025 13:10
@sentrivana sentrivana requested review from antonpirker and removed request for a team April 4, 2025 13:10
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, stuff like this always very satisfying :-)

@sentrivana sentrivana merged commit 4f0651e into potel-base Apr 9, 2025
127 checks passed
@sentrivana sentrivana deleted the ivana/drop-framework-support branch April 9, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for old versions of frameworks in POTel Remove support for trytond<5 in new major

2 participants