Skip to content

Conversation

sentrivana
Copy link
Contributor

  • try to refetch data if PyPI returns an error
  • if we fail after 3 tries, fail the whole script (it doesn't make sense to run it without access to up-to-date PyPI data)

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (adcfa0f) to head (72aabf3).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4251      +/-   ##
==========================================
- Coverage   79.54%   79.51%   -0.04%     
==========================================
  Files         142      142              
  Lines       15898    15898              
  Branches     2721     2721              
==========================================
- Hits        12646    12641       -5     
- Misses       2388     2390       +2     
- Partials      864      867       +3     

see 5 files with indirect coverage changes

@sentrivana sentrivana changed the title toxgen: Fail if we fail to fetch PyPI data toxgen: Retry & fail if we fail to fetch PyPI data Apr 8, 2025
@sentrivana sentrivana marked this pull request as ready for review April 8, 2025 10:43
@sentrivana sentrivana requested a review from a team as a code owner April 8, 2025 10:43
@sentrivana sentrivana requested a review from antonpirker April 8, 2025 10:43
@sentrivana sentrivana merged commit 2ba4ed0 into master Apr 9, 2025
138 checks passed
@sentrivana sentrivana deleted the ivana/update-tox-yet-again branch April 9, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants