ci: Replace `black` and `flake8` with `ruff`. #4866

antonpirker · 2025-09-26T07:34:46Z

Description

Replace black and flake8 with ruff.

With this change also reformat the code base (only minor changes, because the configuration is basically the same.) The commits for the reformatting are not included in git blame calls (see .git-blame-ignore-revs).

Also updates the pre-commit config so we have exactly the same linting/formatting in CI and local dev.

We now have:

Less dependencies
Less configuration
Faster

Issues

resolves: Use ruff for linting/formatting #2527

This commit only contains formatting changes with no functional modifications.

codecov · 2025-09-26T09:12:33Z

❌ 25 Tests Failed:

Tests completed	Failed	Passed	Skipped
23504	25	23479	2303

View the top 3 failed test(s) by shortest run time

tests.integrations.aws_lambda.test_aws_lambda::test_basic_exception

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_error_has_existing_trace_context[RaiseErrorPerformanceDisabled]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_error_has_existing_trace_context[RaiseErrorPerformanceEnabled]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_error_has_new_trace_context[RaiseErrorPerformanceDisabled]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_error_has_new_trace_context[RaiseErrorPerformanceEnabled]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_headers[empty dict headers]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_headers[empty list headers]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_headers[empty string headers]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_headers[no headers]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_headers[none headers]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_init_error

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_non_dict_event[event as bool]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_non_dict_event[event as dict]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_non_dict_event[event as empty list]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_non_dict_event[event as float]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_non_dict_event[event as integer]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_non_dict_event[event as list of dicts]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_non_dict_event[event as string]

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_request_data

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_span_origin

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_timeout_error

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_trace_continuation

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.aws_lambda.test_aws_lambda::test_traces_sampler_has_correct_sampling_context

Stack Traces | 0s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

tests.integrations.sanic.test_sanic::test_transactions[test_config3]

Stack Traces | 0.122s run time

.../integrations/sanic/test_sanic.py:419: in test_transactions
    with c as client:
.tox/py3.10-sanic-v23.12.2/lib/python3.10........./site-packages/sanic_testing/reusable.py:65: in __enter__
    self.run()
.tox/py3.10-sanic-v23.12.2/lib/python3.10........./site-packages/sanic_testing/reusable.py:77: in run
    self._server = self._run(self._server_co)
.tox/py3.10-sanic-v23.12.2/lib/python3.10........./site-packages/sanic_testing/reusable.py:198: in _run
    return self._loop.run_until_complete(coro)
.../hostedtoolcache/Python/3.10.18....../x64/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
.tox/py3.10-sanic-v23.12.2/lib/python3.10.../sanic/mixins/startup.py:612: in create_server
    return await serve(
.tox/py3.10-sanic-v23.12.2/lib/python3.10.../sanic/server/async_server.py:113: in __await__
    self.server = task.result()
.../hostedtoolcache/Python/3.10.18....../x64/lib/python3.10/asyncio/base_events.py:1519: in create_server
    raise OSError(err.errno, 'error while attempting '
E   OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 33298): address already in use

tests.integrations.aws_lambda.test_aws_lambda::test_basic_no_exception

Stack Traces | 83.1s run time

.../integrations/aws_lambda/test_aws_lambda.py:70: in test_environment
    LocalLambdaStack.wait_for_stack()
.../integrations/aws_lambda/utils.py:221: in wait_for_stack
    raise TimeoutError(
E   TimeoutError: AWS SAM failed to start within 60 seconds. (Maybe Docker is not running?)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

sentrivana

Cool!

Using ruff for linting

250c855

antonpirker changed the title ~~Using ruff for linting~~ Using ruff for linting Sep 26, 2025

antonpirker added 17 commits September 26, 2025 09:41

update

c8cffde

Working ruff setup

d164e8c

format

9ad768b

style: Apply ruff formatting to codebase

6d02237

This commit only contains formatting changes with no functional modifications.

git: Ignore formatting commit in git blame

b48773e

style: Apply ruff formatting to codebase

afea4a0

This commit only contains formatting changes with no functional modifications.

git: Ignore formatting commit in git blame

fb48520

tests

c2b574e

update pre-commit to use ruff

ce57df8

style: Apply ruff formatting to codebase

23a340a

This commit only contains formatting changes with no functional modifications.

git: Ignore formatting commit in git blame

70c6a84

Remove because it is done by ruff-format

f4939fb

ruff uses config from pyproject.toml anyhow

bfca27e

Remove obsolete flake8 and black config

1964bc0

Cleanup

efefde9

update comment

ac96fb1

cleanup

b55a9e7

antonpirker changed the title ~~Using ruff for linting~~ Replace black and flake8 with ruff. Sep 26, 2025

antonpirker added 3 commits September 26, 2025 11:16

cleanup

ec9b6e6

cleanup

745b556

updated tests

d135e07

antonpirker changed the title ~~Replace black and flake8 with ruff.~~ ci: Replace black and flake8 with ruff. Sep 26, 2025

antonpirker marked this pull request as ready for review September 26, 2025 09:41

antonpirker requested a review from a team as a code owner September 26, 2025 09:41

sentrivana approved these changes Sep 26, 2025

View reviewed changes

antonpirker merged commit ceefa69 into master Sep 26, 2025
113 checks passed

antonpirker deleted the antonpirker/linting-with-ruff branch September 26, 2025 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: Replace `black` and `flake8` with `ruff`. #4866

ci: Replace `black` and `flake8` with `ruff`. #4866

Uh oh!

antonpirker commented Sep 26, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

sentrivana left a comment

Uh oh!

Uh oh!

Uh oh!

ci: Replace black and flake8 with ruff. #4866

ci: Replace black and flake8 with ruff. #4866

Uh oh!

Conversation

antonpirker commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 25 Tests Failed:

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ci: Replace `black` and `flake8` with `ruff`. #4866

ci: Replace `black` and `flake8` with `ruff`. #4866

antonpirker commented Sep 26, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading