-
Notifications
You must be signed in to change notification settings - Fork 561
fix(openai-agents): also emit spans for MCP tool calls done by the LLM #4875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
constantinius
wants to merge
7
commits into
master
Choose a base branch
from
constantinius/fix/openai-agents/mcp-execute-tool-spans
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(openai-agents): also emit spans for MCP tool calls done by the LLM #4875
constantinius
wants to merge
7
commits into
master
from
constantinius/fix/openai-agents/mcp-execute-tool-spans
+330
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sentrivana
reviewed
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the cursor comment -- might have a point.
Looks good to me otherwise, but please also add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We cannot directly intercept MCP Tool calls, as they are done remotely by the LLM and not in the Agent itself. However, we see when such a tool call took place, so we can emit a zero-length span with the tool call specifics. It will start at the same time as the parent span.
Closes https://linear.app/getsentry/issue/TET-1192/openai-agents-hosted-mcp-calls-cannot-be-wrapped-in-an-execute-tool
Note
Emit execute_tool spans for MCP tool calls detected in agent results, with tool metadata, input/output (PII-gated), and error status.
utils._create_mcp_execute_tool_spans
to emitOP.GEN_AI_EXECUTE_TOOL
spans for MCP tool calls (McpCall
) found inresult.output
.GEN_AI_TOOL_TYPE=mcp
,GEN_AI_TOOL_NAME
, propagates input/output when PII allowed, and marksSPANSTATUS.ERROR
on error.spans/ai_client.update_ai_client_span
to create these tool spans after setting usage/input/output data.SPANSTATUS
andOP
.Written by Cursor Bugbot for commit 96df8c1. This will update automatically on new commits. Configure here.