Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Oct 21, 2025

Description

The check fails on #4896 because repr does not throw an exception with a deeply nested list only on the GitHub CI and only with Python 3.14. Locally, the representation of the deeply nested list is replaced with <broken repr>, but on CI two thousand square brackets are added to the event and the JSON size assertion is exceeded.

def safe_repr(value):
# type: (Any) -> str
try:
return repr(value)
except Exception:
return "<broken repr>"

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner October 21, 2025 06:22
cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 21, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
25334 1 25333 1854
View the top 1 failed test(s) by shortest run time
tests.tracing.test_decorator::test_trace_decorator_async_no_trx
Stack Traces | 0.031s run time
tests/tracing/test_decorator.py:81: in test_trace_decorator_async_no_trx
    fake_debug.assert_called_once_with(
.../hostedtoolcache/Python/3.14.0.../x64/lib/python3.14/unittest/mock.py:996: in assert_called_once_with
    raise AssertionError(msg)
E   AssertionError: Expected 'mock' to be called once. Called 3 times.
E   Calls: [call('[Monitor] health check negative, downsampling with a factor of %d', 10),
E    call('Cannot create a child span for %s. Please start a Sentry transaction before calling this function.', 'time.sleep'),
E    call('Cannot create a child span for %s. Please start a Sentry transaction before calling this function.', 'test_decorator.my_async_example_function')].

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft October 21, 2025 06:45
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review October 21, 2025 07:13
@alexander-alderman-webb alexander-alderman-webb merged commit 0ef47ad into ivana/python-3.14 Oct 21, 2025
114 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/fix-databag-depth branch October 21, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants