Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry_sdk/consts.py
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,7 @@ def __init__(
before_send_log=None, # type: Optional[Callable[[Log, Hint], Optional[Log]]]
trace_ignore_status_codes=frozenset(), # type: AbstractSet[int]
enable_metrics=True, # type: bool
before_send_metric=None, # type: Optional[Callable[[Metric, Hint], Optional[Metric]]]
):
# type: (...) -> None
"""Initialize the Sentry SDK with the given parameters. All parameters described here can be used in a call to `sentry_sdk.init()`.
Expand Down
4 changes: 3 additions & 1 deletion sentry_sdk/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -2060,4 +2060,6 @@ def get_before_send_metric(options):
if options is None:
return None

return options["_experiments"].get("before_send_metric")
return options.get("before_send_metric") or options["_experiments"].get(
"before_send_metric"
)
39 changes: 39 additions & 0 deletions tests/test_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,45 @@ def test_metrics_tracing_without_performance(sentry_init, capture_envelopes):
def test_metrics_before_send(sentry_init, capture_envelopes):
before_metric_called = False

def _before_metric(record, hint):
nonlocal before_metric_called

assert set(record.keys()) == {
"timestamp",
"trace_id",
"span_id",
"name",
"type",
"value",
"unit",
"attributes",
}

if record["name"] == "test.skip":
return None

before_metric_called = True
return record

sentry_init(
before_send_metric=_before_metric,
)
envelopes = capture_envelopes()

sentry_sdk.metrics.count("test.skip", 1)
sentry_sdk.metrics.count("test.keep", 1)

get_client().flush()

metrics = envelopes_to_metrics(envelopes)
assert len(metrics) == 1
assert metrics[0]["name"] == "test.keep"
assert before_metric_called


def test_metrics_experimental_before_send(sentry_init, capture_envelopes):
before_metric_called = False

def _before_metric(record, hint):
nonlocal before_metric_called

Expand Down