Skip to content

fix(metro): Fixes Metro 0.83.2 sentry-cli issue #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

fix(metro): Fixes Metro 0.83.2 sentry-cli issue #5209

merged 1 commit into from
Sep 25, 2025

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Sep 25, 2025 •
edited
Loading

This reverts commit 985e404.

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes #5207

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.14 ms 387.40 ms -10.74 ms
Size 17.75 MiB 19.68 MiB 1.94 MiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 347.04 ms 394.76 ms 47.72 ms
Size 7.15 MiB 8.41 MiB 1.26 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.24 ms 1233.31 ms 11.06 ms
Size 2.63 MiB 3.96 MiB 1.33 MiB

@antonis antonis marked this pull request as ready for review September 25, 2025 14:33
@antonis antonis merged commit dacc3f9 into antonis/fix-metro0.83.2-breakage Sep 25, 2025
64 of 72 checks passed
@antonis antonis deleted the antonis/fix-sentry-cli branch September 25, 2025 14:34
@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.08 ms 1227.71 ms 5.63 ms
Size 3.19 MiB 4.53 MiB 1.35 MiB

@antonis
Copy link
Contributor Author

antonis commented Sep 25, 2025

Merging since the issue seems to already be fixed by the parent PR

antonis added a commit that referenced this pull request Sep 26, 2025
@antonis
fix(metro): Fixes Metro 0.83.2 breakages (#5206)
1b4d764 
* Fixes baseJSBundle resolution

* Fixes bundleToString resolution

* Temporarily set SENTRY_DISABLE_AUTO_UPLOAD to true

* Add changelog

* Revert "Temporarily set SENTRY_DISABLE_AUTO_UPLOAD to true" (#5209)

This reverts commit 985e404.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx Awaiting requested review from alwx

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@antonis