Skip to content

Conversation

@lucas-zimerman
Copy link
Collaborator

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- test nocache ([#5211](https://github.com/getsentry/sentry-react-native/pull/5211))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against f99799e

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.43 ms 440.29 ms 43.86 ms
Size 17.75 MiB 19.68 MiB 1.94 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
534ba8c 484.00 ms 499.93 ms 15.93 ms
818a608 495.84 ms 498.08 ms 2.25 ms
21c9e75 450.39 ms 452.92 ms 2.53 ms
6fee48d+dirty 407.42 ms 437.71 ms 30.29 ms
7be1f99 454.83 ms 461.36 ms 6.53 ms
c4e097a 338.06 ms 439.36 ms 101.30 ms
69602ce 417.47 ms 443.52 ms 26.05 ms
000da7a 454.46 ms 445.00 ms -9.46 ms
5c16cdc+dirty 423.48 ms 452.35 ms 28.88 ms
c7f264b 434.98 ms 452.96 ms 17.98 ms

App size

Revision Plain With Sentry Diff
534ba8c 17.75 MiB 20.15 MiB 2.41 MiB
818a608 17.75 MiB 19.68 MiB 1.94 MiB
21c9e75 17.75 MiB 20.15 MiB 2.41 MiB
6fee48d+dirty 17.75 MiB 19.68 MiB 1.94 MiB
7be1f99 17.75 MiB 20.15 MiB 2.41 MiB
c4e097a 17.75 MiB 19.68 MiB 1.94 MiB
69602ce 17.75 MiB 19.68 MiB 1.94 MiB
000da7a 17.75 MiB 19.68 MiB 1.94 MiB
5c16cdc+dirty 17.75 MiB 19.68 MiB 1.94 MiB
c7f264b 17.75 MiB 19.68 MiB 1.94 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 377.96 ms 398.56 ms 20.61 ms
Size 7.15 MiB 8.41 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
69602ce+dirty 375.37 ms 405.28 ms 29.91 ms
a02e30b+dirty 346.13 ms 381.76 ms 35.62 ms
98f632c+dirty 323.98 ms 375.39 ms 51.41 ms
818a608+dirty 350.29 ms 397.38 ms 47.09 ms
c4e097a+dirty 382.43 ms 443.77 ms 61.34 ms
6fee48d+dirty 370.23 ms 427.86 ms 57.63 ms
bc9680d+dirty 346.77 ms 463.48 ms 116.71 ms
5c16cdc+dirty 375.45 ms 426.62 ms 51.17 ms
e2fa43d+dirty 326.56 ms 372.88 ms 46.32 ms
ba75c7c+dirty 377.92 ms 417.74 ms 39.83 ms

App size

Revision Plain With Sentry Diff
69602ce+dirty 7.15 MiB 8.41 MiB 1.26 MiB
a02e30b+dirty 7.15 MiB 8.42 MiB 1.27 MiB
98f632c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
818a608+dirty 7.15 MiB 8.41 MiB 1.26 MiB
c4e097a+dirty 7.15 MiB 8.41 MiB 1.26 MiB
6fee48d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
bc9680d+dirty 7.15 MiB 8.42 MiB 1.27 MiB
5c16cdc+dirty 7.15 MiB 8.41 MiB 1.26 MiB
e2fa43d+dirty 7.15 MiB 8.42 MiB 1.27 MiB
ba75c7c+dirty 7.15 MiB 8.42 MiB 1.27 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.18 ms 1214.10 ms 9.92 ms
Size 2.63 MiB 3.98 MiB 1.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms
20daa0a+dirty 1233.12 ms 1233.35 ms 0.22 ms
46bd012+dirty 1220.49 ms 1226.89 ms 6.40 ms
5526494+dirty 1224.73 ms 1229.08 ms 4.36 ms
46da307+dirty 1217.08 ms 1224.16 ms 7.08 ms
d916aa3+dirty 1221.02 ms 1228.98 ms 7.96 ms
af9331b+dirty 1233.61 ms 1230.50 ms -3.11 ms
6479fd5+dirty 1228.48 ms 1231.32 ms 2.84 ms
7480abe+dirty 1220.53 ms 1244.18 ms 23.65 ms
c4e097a+dirty 1229.09 ms 1242.61 ms 13.53 ms

App size

Revision Plain With Sentry Diff
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB
20daa0a+dirty 2.63 MiB 3.81 MiB 1.18 MiB
46bd012+dirty 2.63 MiB 3.81 MiB 1.18 MiB
5526494+dirty 2.63 MiB 3.87 MiB 1.24 MiB
46da307+dirty 2.63 MiB 3.87 MiB 1.24 MiB
d916aa3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
af9331b+dirty 2.63 MiB 3.91 MiB 1.28 MiB
6479fd5+dirty 2.63 MiB 3.96 MiB 1.33 MiB
7480abe+dirty 2.63 MiB 3.96 MiB 1.33 MiB
c4e097a+dirty 2.63 MiB 3.87 MiB 1.24 MiB

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1205.22 ms 1213.57 ms 8.35 ms
Size 3.19 MiB 4.54 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21c9e75+dirty 1206.20 ms 1223.54 ms 17.35 ms
20daa0a+dirty 1227.71 ms 1233.72 ms 6.01 ms
46bd012+dirty 1231.78 ms 1212.30 ms -19.47 ms
5526494+dirty 1217.06 ms 1222.26 ms 5.20 ms
46da307+dirty 1213.45 ms 1207.96 ms -5.49 ms
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
af9331b+dirty 1230.08 ms 1233.24 ms 3.16 ms
6479fd5+dirty 1207.80 ms 1215.12 ms 7.32 ms
7480abe+dirty 1219.84 ms 1223.60 ms 3.76 ms
c4e097a+dirty 1231.35 ms 1246.91 ms 15.56 ms

App size

Revision Plain With Sentry Diff
21c9e75+dirty 3.19 MiB 4.38 MiB 1.19 MiB
20daa0a+dirty 3.19 MiB 4.38 MiB 1.19 MiB
46bd012+dirty 3.19 MiB 4.38 MiB 1.19 MiB
5526494+dirty 3.19 MiB 4.44 MiB 1.25 MiB
46da307+dirty 3.19 MiB 4.44 MiB 1.25 MiB
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
af9331b+dirty 3.19 MiB 4.48 MiB 1.29 MiB
6479fd5+dirty 3.19 MiB 4.53 MiB 1.35 MiB
7480abe+dirty 3.19 MiB 4.53 MiB 1.35 MiB
c4e097a+dirty 3.19 MiB 4.44 MiB 1.25 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant