Skip to content

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Sep 29, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Reverts the changes in #5216 due to the introduced breakages preventing the flows from running correctly.

The bump will be tackled with #5218 after the issues are fixed

💡 Motivation and Context

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

github-actions bot commented Sep 29, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.33 ms 424.64 ms 68.31 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21c9e75+dirty 356.73 ms 381.06 ms 24.33 ms
ba75c7c+dirty 377.92 ms 417.74 ms 39.83 ms
c7f264b+dirty 356.98 ms 407.46 ms 50.48 ms
af9331b+dirty 374.42 ms 425.68 ms 51.26 ms
e2fa43d+dirty 326.56 ms 372.88 ms 46.32 ms
ec14be7+dirty 401.58 ms 475.26 ms 73.68 ms
23080e5+dirty 347.29 ms 381.87 ms 34.58 ms
f70acbf+dirty 520.12 ms 558.91 ms 38.79 ms
6fee48d+dirty 370.23 ms 427.86 ms 57.63 ms
7be1f99+dirty 369.02 ms 399.60 ms 30.58 ms

App size

Revision Plain With Sentry Diff
21c9e75+dirty 7.15 MiB 8.42 MiB 1.27 MiB
ba75c7c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
c7f264b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
af9331b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
e2fa43d+dirty 7.15 MiB 8.42 MiB 1.27 MiB
ec14be7+dirty 7.15 MiB 8.42 MiB 1.26 MiB
23080e5+dirty 7.15 MiB 8.41 MiB 1.26 MiB
f70acbf+dirty 7.15 MiB 8.41 MiB 1.26 MiB
6fee48d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
7be1f99+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Previous results on branch: antonis/rollback-workflows-to-v2

Startup times

Revision Plain With Sentry Diff
75dec0e+dirty 469.84 ms 453.65 ms -16.19 ms

App size

Revision Plain With Sentry Diff
75dec0e+dirty 7.15 MiB 8.42 MiB 1.26 MiB

Copy link
Contributor

github-actions bot commented Sep 29, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.04 ms 1208.39 ms -0.65 ms
Size 2.63 MiB 3.98 MiB 1.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2fa43d+dirty 1216.04 ms 1232.65 ms 16.61 ms
c4e097a+dirty 1229.09 ms 1242.61 ms 13.53 ms
7480abe+dirty 1220.53 ms 1244.18 ms 23.65 ms
785ffb1+dirty 1237.63 ms 1240.50 ms 2.87 ms
af9331b+dirty 1233.61 ms 1230.50 ms -3.11 ms
818a608+dirty 1205.76 ms 1208.00 ms 2.24 ms
8a4ce6f+dirty 1221.31 ms 1219.84 ms -1.47 ms
46bd012+dirty 1220.49 ms 1226.89 ms 6.40 ms
276d348+dirty 1224.22 ms 1227.38 ms 3.16 ms
c08359e+dirty 1235.25 ms 1233.96 ms -1.29 ms

App size

Revision Plain With Sentry Diff
e2fa43d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
c4e097a+dirty 2.63 MiB 3.87 MiB 1.24 MiB
7480abe+dirty 2.63 MiB 3.96 MiB 1.33 MiB
785ffb1+dirty 2.63 MiB 3.81 MiB 1.18 MiB
af9331b+dirty 2.63 MiB 3.91 MiB 1.28 MiB
818a608+dirty 2.63 MiB 3.91 MiB 1.28 MiB
8a4ce6f+dirty 2.63 MiB 3.96 MiB 1.33 MiB
46bd012+dirty 2.63 MiB 3.81 MiB 1.18 MiB
276d348+dirty 2.63 MiB 3.98 MiB 1.34 MiB
c08359e+dirty 2.63 MiB 3.81 MiB 1.18 MiB

Previous results on branch: antonis/rollback-workflows-to-v2

Startup times

Revision Plain With Sentry Diff
75dec0e+dirty 1225.55 ms 1231.10 ms 5.55 ms

App size

Revision Plain With Sentry Diff
75dec0e+dirty 2.63 MiB 3.98 MiB 1.34 MiB

Copy link
Contributor

github-actions bot commented Sep 29, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.69 ms 1211.39 ms 2.70 ms
Size 3.19 MiB 4.54 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2fa43d+dirty 1224.43 ms 1235.40 ms 10.98 ms
c4e097a+dirty 1231.35 ms 1246.91 ms 15.56 ms
7480abe+dirty 1219.84 ms 1223.60 ms 3.76 ms
785ffb1+dirty 1213.71 ms 1213.37 ms -0.35 ms
af9331b+dirty 1230.08 ms 1233.24 ms 3.16 ms
818a608+dirty 1218.84 ms 1223.18 ms 4.34 ms
8a4ce6f+dirty 1232.80 ms 1223.80 ms -9.00 ms
46bd012+dirty 1231.78 ms 1212.30 ms -19.47 ms
276d348+dirty 1222.10 ms 1229.02 ms 6.92 ms
c08359e+dirty 1200.59 ms 1211.81 ms 11.22 ms

App size

Revision Plain With Sentry Diff
e2fa43d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
c4e097a+dirty 3.19 MiB 4.44 MiB 1.25 MiB
7480abe+dirty 3.19 MiB 4.53 MiB 1.35 MiB
785ffb1+dirty 3.19 MiB 4.38 MiB 1.19 MiB
af9331b+dirty 3.19 MiB 4.48 MiB 1.29 MiB
818a608+dirty 3.19 MiB 4.48 MiB 1.29 MiB
8a4ce6f+dirty 3.19 MiB 4.53 MiB 1.34 MiB
46bd012+dirty 3.19 MiB 4.38 MiB 1.19 MiB
276d348+dirty 3.19 MiB 4.54 MiB 1.36 MiB
c08359e+dirty 3.19 MiB 4.38 MiB 1.19 MiB

Previous results on branch: antonis/rollback-workflows-to-v2

Startup times

Revision Plain With Sentry Diff
75dec0e+dirty 1228.43 ms 1227.15 ms -1.28 ms

App size

Revision Plain With Sentry Diff
75dec0e+dirty 3.19 MiB 4.54 MiB 1.36 MiB

Copy link
Contributor

github-actions bot commented Sep 29, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 402.58 ms 454.87 ms 52.29 ms
Size 17.75 MiB 19.69 MiB 1.94 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a0b15d6 423.06 ms 437.77 ms 14.71 ms
20d5eaa 377.62 ms 406.50 ms 28.88 ms
c7f264b 434.98 ms 452.96 ms 17.98 ms
e2fa43d 451.68 ms 462.42 ms 10.74 ms
ba75c7c 367.72 ms 369.16 ms 1.44 ms
9f211e3 451.50 ms 500.00 ms 48.50 ms
785ffb1 471.92 ms 460.96 ms -10.96 ms
ec14be7+dirty 403.50 ms 411.46 ms 7.96 ms
f70acbf+dirty 373.39 ms 382.81 ms 9.43 ms
1853710 555.47 ms 556.59 ms 1.12 ms

App size

Revision Plain With Sentry Diff
a0b15d6 17.75 MiB 20.15 MiB 2.41 MiB
20d5eaa 17.75 MiB 20.15 MiB 2.41 MiB
c7f264b 17.75 MiB 19.68 MiB 1.94 MiB
e2fa43d 17.75 MiB 20.15 MiB 2.41 MiB
ba75c7c 17.75 MiB 20.15 MiB 2.41 MiB
9f211e3 17.75 MiB 19.68 MiB 1.94 MiB
785ffb1 17.75 MiB 20.15 MiB 2.41 MiB
ec14be7+dirty 17.75 MiB 19.69 MiB 1.94 MiB
f70acbf+dirty 17.75 MiB 19.68 MiB 1.94 MiB
1853710 17.75 MiB 19.68 MiB 1.94 MiB

Previous results on branch: antonis/rollback-workflows-to-v2

Startup times

Revision Plain With Sentry Diff
75dec0e+dirty 396.69 ms 406.49 ms 9.80 ms

App size

Revision Plain With Sentry Diff
75dec0e+dirty 17.75 MiB 19.69 MiB 1.94 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis enabled auto-merge (squash) September 30, 2025 07:24
@antonis antonis merged commit 6a70a7e into main Sep 30, 2025
65 checks passed
@antonis antonis deleted the antonis/rollback-workflows-to-v2 branch September 30, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants