-
-
Notifications
You must be signed in to change notification settings - Fork 354
chore(deps): Bump Android Session Replay Stub jar for 8.22.0 #5229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
23080e5 | 384.85 ms | 382.57 ms | -2.28 ms |
1853710 | 555.47 ms | 556.59 ms | 1.12 ms |
77061ed+dirty | 369.55 ms | 408.35 ms | 38.80 ms |
20d5eaa | 377.62 ms | 406.50 ms | 28.88 ms |
f70acbf+dirty | 373.39 ms | 382.81 ms | 9.43 ms |
6479fd5+dirty | 412.95 ms | 434.02 ms | 21.07 ms |
8ece263 | 441.96 ms | 444.96 ms | 3.00 ms |
af9331b | 449.77 ms | 479.20 ms | 29.43 ms |
a0b15d6 | 423.06 ms | 437.77 ms | 14.71 ms |
46da307 | 455.92 ms | 443.79 ms | -12.13 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
23080e5 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
1853710 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
77061ed+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
20d5eaa | 17.75 MiB | 20.15 MiB | 2.41 MiB |
f70acbf+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
6479fd5+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
8ece263 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
af9331b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
a0b15d6 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
46da307 | 17.75 MiB | 19.68 MiB | 1.93 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bc9680d+dirty | 1221.41 ms | 1241.47 ms | 20.06 ms |
c9e95bd+dirty | 1240.19 ms | 1246.33 ms | 6.14 ms |
c1573b3+dirty | 1203.33 ms | 1202.47 ms | -0.86 ms |
49ef936+dirty | 1228.42 ms | 1217.09 ms | -11.33 ms |
8d89cc9+dirty | 1222.92 ms | 1239.43 ms | 16.51 ms |
e2fa43d+dirty | 1216.04 ms | 1232.65 ms | 16.61 ms |
9f211e3+dirty | 1218.80 ms | 1233.88 ms | 15.08 ms |
7be1f99+dirty | 1226.69 ms | 1217.76 ms | -8.93 ms |
21c9e75+dirty | 1237.78 ms | 1247.66 ms | 9.88 ms |
5c16cdc+dirty | 1209.32 ms | 1210.67 ms | 1.35 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bc9680d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
c9e95bd+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
c1573b3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
49ef936+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
8d89cc9+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
e2fa43d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
9f211e3+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
7be1f99+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
21c9e75+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
5c16cdc+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77061ed+dirty | 359.40 ms | 424.10 ms | 64.70 ms |
95aaf8a+dirty | 342.82 ms | 393.75 ms | 50.93 ms |
f70acbf+dirty | 520.12 ms | 558.91 ms | 38.79 ms |
6479fd5+dirty | 393.06 ms | 434.04 ms | 40.98 ms |
c7f264b+dirty | 356.98 ms | 407.46 ms | 50.48 ms |
d916aa3+dirty | 411.72 ms | 451.76 ms | 40.03 ms |
20daa0a+dirty | 352.33 ms | 424.30 ms | 71.98 ms |
e2fa43d+dirty | 326.56 ms | 372.88 ms | 46.32 ms |
785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
46bd012+dirty | 333.76 ms | 359.24 ms | 25.48 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77061ed+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
95aaf8a+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
f70acbf+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
6479fd5+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
c7f264b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
d916aa3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
20daa0a+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
e2fa43d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
46bd012+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bc9680d+dirty | 1228.57 ms | 1233.64 ms | 5.07 ms |
c9e95bd+dirty | 1205.83 ms | 1207.38 ms | 1.55 ms |
c1573b3+dirty | 1245.69 ms | 1245.48 ms | -0.21 ms |
49ef936+dirty | 1221.27 ms | 1221.60 ms | 0.34 ms |
8d89cc9+dirty | 1232.35 ms | 1228.53 ms | -3.82 ms |
e2fa43d+dirty | 1224.43 ms | 1235.40 ms | 10.98 ms |
9f211e3+dirty | 1215.38 ms | 1218.15 ms | 2.77 ms |
7be1f99+dirty | 1222.43 ms | 1217.15 ms | -5.28 ms |
21c9e75+dirty | 1206.20 ms | 1223.54 ms | 17.35 ms |
5c16cdc+dirty | 1235.67 ms | 1241.18 ms | 5.51 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bc9680d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
c9e95bd+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
c1573b3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
49ef936+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
8d89cc9+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
e2fa43d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
9f211e3+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
7be1f99+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
21c9e75+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
5c16cdc+dirty | 3.19 MiB | 4.53 MiB | 1.34 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to review a binary file only PR.
LGTM!
Sorry for this. It's just the result of building the project with the latest stub dependency. I should have bumped this along the automated deps PR but I now figured out that this is needed. |
📢 Type of change
📜 Description
Following up on this conversation bumps the .jar after #5194
💡 Motivation and Context
#5226 (comment)
💚 How did you test it?
CI
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
#skip-changelog