Skip to content

chore(deps): bump getsentry/github-workflows from 2 to 3 #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(deps): bump getsentry/github-workflows from 2 to 3 #5240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/danger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ on:

jobs:
danger:
uses: getsentry/github-workflows/.github/workflows/danger.yml@v2
uses: getsentry/github-workflows/.github/workflows/danger.yml@v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The workflow references v3 but uses the incorrect v2 invocation syntax (.github/workflows/danger.yml@v3), which is a breaking change that will cause the action to fail.

  • Description: The GitHub workflow is being upgraded to use getsentry/github-workflows@v3. However, the invocation syntax remains the v2 style, referencing the full workflow path like .github/workflows/danger.yml@v3. The v3 version of this workflow is a composite action and requires a different syntax, such as getsentry/github-workflows/danger@v3. This mismatch will cause the GitHub Actions runner to fail when trying to locate and execute the workflow. This will prevent essential CI/CD jobs from running. A previous attempt to upgrade this repository reportedly failed due to this exact issue.

  • Suggested fix: Update the uses clause in the workflow file to use the correct v3 composite action syntax. For example, change uses: getsentry/github-workflows/.github/workflows/danger.yml@v3 to uses: getsentry/github-workflows/danger@v3. This change should be applied to all affected workflows.
    severity: 0.85, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

20 changes: 10 additions & 10 deletions .github/workflows/update-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
android:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-android.sh
name: Android SDK
Expand All @@ -20,7 +20,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

android-stubs:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-android-stubs.sh
name: Android SDK Stubs
Expand All @@ -29,7 +29,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

cocoa:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-cocoa.sh
name: Cocoa SDK
Expand All @@ -38,7 +38,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

javascript:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-javascript.sh
name: JavaScript SDK
Expand All @@ -47,7 +47,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

wizard:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-wizard.sh
name: Wizard
Expand All @@ -57,7 +57,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

cli:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-cli.sh
name: CLI
Expand All @@ -66,7 +66,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

bundler-plugins:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-bundler-plugins.sh
name: Bundler Plugins
Expand All @@ -75,7 +75,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

sample-rn:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-rn.sh
name: React Native
Expand All @@ -86,7 +86,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

maestro:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-maestro.sh
name: Maestro
Expand All @@ -97,7 +97,7 @@ jobs:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

sentry-android-gradle-plugin:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
uses: getsentry/github-workflows/.github/workflows/updater.yml@v3
with:
path: scripts/update-sentry-android-gradle-plugin.sh
name: Sentry Android Gradle Plugin
Expand Down
Loading