Skip to content

chore: test updater workflow #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: test updater workflow #5252

wants to merge 1 commit into from
+0 −2

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 9, 2025

Tests whether updater has permission issues when running in a pr branch. Related to #5218 and getsentry/github-workflows#128

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@vaind
chore: test updater workflow
b39c8e4 
Tests whether updater has permission issues when running in a pr branch. Related to #5218 and getsentry/github-workflows#128
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- test updater workflow ([#5252](https://github.com/getsentry/sentry-react-native/pull/5252))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against b39c8e4

@vaind vaind closed this Oct 9, 2025
@vaind vaind deleted the vaind-patch-1 branch October 9, 2025 10:10
@vaind vaind mentioned this pull request Oct 9, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 406.83 ms 416.12 ms 9.29 ms
Size 17.75 MiB 19.70 MiB 1.95 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
534ba8c 484.00 ms 499.93 ms 15.93 ms
c08359e 421.87 ms 445.37 ms 23.50 ms
49ef936+dirty 405.96 ms 417.22 ms 11.26 ms
3099014+dirty 439.20 ms 468.40 ms 29.20 ms
1853710 555.47 ms 556.59 ms 1.12 ms
170d5ea+dirty 407.92 ms 422.49 ms 14.57 ms
c9e95bd 428.04 ms 458.70 ms 30.65 ms
5526494 440.84 ms 448.36 ms 7.52 ms
276d348+dirty 375.48 ms 403.76 ms 28.28 ms
d751a5d+dirty 434.24 ms 486.08 ms 51.84 ms

App size

Revision Plain With Sentry Diff
534ba8c 17.75 MiB 20.15 MiB 2.41 MiB
c08359e 17.75 MiB 20.15 MiB 2.41 MiB
49ef936+dirty 17.75 MiB 19.69 MiB 1.94 MiB
3099014+dirty 17.75 MiB 19.70 MiB 1.95 MiB
1853710 17.75 MiB 19.68 MiB 1.94 MiB
170d5ea+dirty 17.75 MiB 19.70 MiB 1.95 MiB
c9e95bd 17.75 MiB 19.68 MiB 1.93 MiB
5526494 17.75 MiB 19.68 MiB 1.93 MiB
276d348+dirty 17.75 MiB 19.69 MiB 1.94 MiB
d751a5d+dirty 17.75 MiB 19.68 MiB 1.94 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.33 ms 1231.24 ms 8.92 ms
Size 2.63 MiB 3.99 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
64cd15c+dirty 1216.31 ms 1214.04 ms -2.26 ms
276d348+dirty 1224.22 ms 1227.38 ms 3.16 ms
bfe454a+dirty 1235.33 ms 1243.12 ms 7.79 ms
d916aa3+dirty 1221.02 ms 1228.98 ms 7.96 ms
7480abe+dirty 1220.53 ms 1244.18 ms 23.65 ms
1bea095+dirty 1234.14 ms 1233.96 ms -0.18 ms
534ba8c+dirty 1230.22 ms 1231.18 ms 0.96 ms
ba75c7c+dirty 1235.86 ms 1226.45 ms -9.41 ms
20daa0a+dirty 1233.12 ms 1233.35 ms 0.22 ms
6479fd5+dirty 1228.48 ms 1231.32 ms 2.84 ms

App size

Revision Plain With Sentry Diff
64cd15c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
276d348+dirty 2.63 MiB 3.98 MiB 1.34 MiB
bfe454a+dirty 2.63 MiB 3.98 MiB 1.34 MiB
d916aa3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
7480abe+dirty 2.63 MiB 3.96 MiB 1.33 MiB
1bea095+dirty 2.63 MiB 3.99 MiB 1.35 MiB
534ba8c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
ba75c7c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
20daa0a+dirty 2.63 MiB 3.81 MiB 1.18 MiB
6479fd5+dirty 2.63 MiB 3.96 MiB 1.33 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 350.45 ms 431.77 ms 81.32 ms
Size 7.15 MiB 8.43 MiB 1.28 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
20d5eaa+dirty 358.31 ms 442.37 ms 84.06 ms
49ef936+dirty 333.72 ms 387.51 ms 53.79 ms
a0b15d6+dirty 414.33 ms 448.85 ms 34.52 ms
5526494+dirty 380.79 ms 432.70 ms 51.91 ms
818a608+dirty 350.29 ms 397.38 ms 47.09 ms
20daa0a+dirty 352.33 ms 424.30 ms 71.98 ms
3e0a5f9+dirty 379.92 ms 450.96 ms 71.04 ms
b3b5b0d+dirty 361.42 ms 403.90 ms 42.48 ms
ba75c7c+dirty 377.92 ms 417.74 ms 39.83 ms
bc9680d+dirty 346.77 ms 463.48 ms 116.71 ms

App size

Revision Plain With Sentry Diff
20d5eaa+dirty 7.15 MiB 8.42 MiB 1.27 MiB
49ef936+dirty 7.15 MiB 8.42 MiB 1.26 MiB
a0b15d6+dirty 7.15 MiB 8.42 MiB 1.27 MiB
5526494+dirty 7.15 MiB 8.41 MiB 1.26 MiB
818a608+dirty 7.15 MiB 8.41 MiB 1.26 MiB
20daa0a+dirty 7.15 MiB 8.42 MiB 1.27 MiB
3e0a5f9+dirty 7.15 MiB 8.42 MiB 1.27 MiB
b3b5b0d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
ba75c7c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
bc9680d+dirty 7.15 MiB 8.42 MiB 1.27 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.74 ms 1231.65 ms 4.90 ms
Size 3.19 MiB 4.55 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
64cd15c+dirty 1213.50 ms 1223.54 ms 10.04 ms
276d348+dirty 1222.10 ms 1229.02 ms 6.92 ms
bfe454a+dirty 1231.82 ms 1239.98 ms 8.16 ms
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
7480abe+dirty 1219.84 ms 1223.60 ms 3.76 ms
1bea095+dirty 1218.93 ms 1212.37 ms -6.57 ms
534ba8c+dirty 1225.00 ms 1237.43 ms 12.43 ms
ba75c7c+dirty 1236.14 ms 1240.69 ms 4.55 ms
20daa0a+dirty 1227.71 ms 1233.72 ms 6.01 ms
6479fd5+dirty 1207.80 ms 1215.12 ms 7.32 ms

App size

Revision Plain With Sentry Diff
64cd15c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
276d348+dirty 3.19 MiB 4.54 MiB 1.36 MiB
bfe454a+dirty 3.19 MiB 4.54 MiB 1.36 MiB
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
7480abe+dirty 3.19 MiB 4.53 MiB 1.35 MiB
1bea095+dirty 3.19 MiB 4.55 MiB 1.37 MiB
534ba8c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
ba75c7c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
20daa0a+dirty 3.19 MiB 4.38 MiB 1.19 MiB
6479fd5+dirty 3.19 MiB 4.53 MiB 1.35 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx Awaiting requested review from alwx alwx will be requested when the pull request is marked ready for review alwx is a code owner

@antonis antonis Awaiting requested review from antonis antonis will be requested when the pull request is marked ready for review antonis is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vaind