Skip to content

Conversation

lcian
Copy link
Member

@lcian lcian commented Sep 25, 2025

#skip-changelog

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.46%. Comparing base (d9cdf34) to head (e736f15).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files          64       64           
  Lines        7518     7518           
=======================================
  Hits         5523     5523           
  Misses       1995     1995           

@lcian
Copy link
Member Author

lcian commented Sep 26, 2025

It seems that the JUnit format output by nextest is not compatible with Prevent/Codecov.

Update: actually it's supported, there's just something unexpected in the UI where it wasn't obvious where I would see the test runs.

@lcian lcian changed the title ci: try Sentry Prevent ci: integrate Sentry Prevent Sep 26, 2025
@lcian lcian marked this pull request as ready for review September 26, 2025 09:45
@lcian lcian enabled auto-merge (squash) September 30, 2025 11:37
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but check comments before merge


- name: Run cargo test
run: cargo test --workspace --all-features --all-targets
- uses: taiki-e/install-action@nextest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may wish to consider pinning GitHub Actions by hash

@lcian lcian merged commit 750dec0 into master Sep 30, 2025
20 checks passed
@lcian lcian deleted the lcian/try-prevent branch September 30, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants