feat: use context to isolate data between requests and messages#997
Open
feat: use context to isolate data between requests and messages#997
Conversation
Contributor
|
I would love to have this merged. I use FrankenPHP and have an issue this PR would fix. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Contradictory assertions in ignored transaction tracing test
- Updated the ignored-transaction assertion to count only non-transaction events so tracing events no longer conflict with the expected tracing event count.
Or push these changes by commenting:
@cursor push ad868baab6
Preview (ad868baab6)
diff --git a/tests/End2End/TracingEnd2EndTest.php b/tests/End2End/TracingEnd2EndTest.php
--- a/tests/End2End/TracingEnd2EndTest.php
+++ b/tests/End2End/TracingEnd2EndTest.php
@@ -72,7 +72,11 @@
private function assertLastEventIdIsNull(KernelBrowser $client): void
{
- $this->assertCount(0, StubTransport::$events, 'Some error was captured');
+ $errorEvents = array_filter(StubTransport::$events, static function (\Sentry\Event $event): bool {
+ return null === $event->getTransaction();
+ });
+
+ $this->assertCount(0, $errorEvents, 'Some error was captured');
}
private function assertTracingEventCount(int $expectedCount): voidThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds the context introduced in getsentry/sentry-php#2011.
The context is used to properly isolate data between requests and messages and prevent data leaking between requests when using worker runtimes such as FrankenPHP or RoadRunner.
Because message context isolation breaks current behaviour, a new flag
isolate_context_by_messageis introduced, which defaults tofalseto keep current behaviour unchanged. When enabled, it will inherit all data that was set before a message is received.