feat(deletes): add stub RPC endpoint for deleting all items in a trace #7416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
MeredithAnya
approved these changes
Sep 17, 2025
kylemumma
reviewed
Sep 18, 2025
|
|
||
| def _execute(self, request: DeleteTraceItemsRequest) -> DeleteTraceItemsResponse: | ||
| if len(request.trace_ids) < 1: | ||
| raise BadSnubaRPCRequestException("trace_id is required for deleting a trace.") |
There was a problem hiding this comment.
i thought its not required if you use filters instead https://github.com/getsentry/sentry-protos/pull/144/files#diff-b15032050ed98d3657b16151b864f74ce9302d56b4d08cb10d392cc96748a971R10
There was a problem hiding this comment.
The first pass of this is only going to support deletion by trace_ids and filters support will come later. If you think it makes things clearer, I can raise a NotImplementedError if filters is set, but practically speaking I don't think anybody will call this endpoint until the details are filled in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For deleting PII in EAP, we aim to start with an approach that mirrors what we do for search_issues. We want the request to arrive through RPC, though. This change creates a stub for allowing a caller to request deleting items for a trace, though it currently does nothing.
I'm separating this out to make the change that involves real functionality smaller.
Requires getsentry/sentry-protos#144
https://linear.app/getsentry/issue/EAP-282/create-new-rpc-endpoint-for-deletion-from-eap-items