-
-
Notifications
You must be signed in to change notification settings - Fork 61
feat(eap): add deletion_settings to eap_items storage definition #7420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
timeout_before_checking_execution_speed: 0 | ||
|
||
deletion_settings: | ||
is_enabled: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will allow the product to make delete queries to the existing endpoint, before I had a runtime config that also enabled things to feature gate it - but anyway maybe you could use the delete_allocation_policies
and set concurrent queries to 0 or something in non S4S
regions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onewland okie so technically what I said is still true but since we haven't set up the topic and the topic mapping it will fail, but I mean eventually when you start testing it out
snuba/snuba/web/bulk_delete_query.py
Lines 50 to 52 in 6c487c6
STORAGE_TOPIC: Mapping[str, Topic] = { | |
StorageKey.SEARCH_ISSUES.value: Topic.LW_DELETIONS_GENERIC_EVENTS | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the total volume of deletes we expect, I think we should trend toward there being only one lightweight delete topic. Messages already contain the storages they delete for and consumer groups could ignore delete messages for other storages (the subscription scheduler does this for followed consumer groups).
Having said that, I'm willing to keep this as-is for now because we're probably going to delete search issues at some point and then eap-items really will be the only storage for the delete pipeline.
I'll also change this to be is_enabled=0 or find some way to disable it before deploying
snuba/datasets/configuration/events_analytics_platform/storages/eap_items.yaml
Show resolved
Hide resolved
✅ All tests passed in 1255.79s |
f2b577b
to
9f7e844
Compare
Provide mechanism for lightweight deletes API to handle eap_items.
https://linear.app/getsentry/issue/EAP-283/enable-eap-items-storage-to-delete-by-trace-id
Depends on getsentry/sentry-kafka-schemas#438
Tested a delete locally by:
curl -H "Content-Type: application/json" -X DELETE http://localhost:1218/eap_items -d "@test-delete.json"
test-delete.json contents:
Before and after delete: