Fix HTTPS issue by using APP_PROTOCOL in axios baseURL #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a compatibility issue with HTTPS when using the Cloudflare Tunnel to expose the Umbrel instance. The issue occurred because axios was configured with a fixed HTTP protocol. By modifying the configuration to use the protocol defined in the APP_PROTOCOL constant, all requests are now correctly made with HTTP or HTTPS as configured, preventing the browser from blocking requests when HTTPS is in use.
aqaffaf
approved these changes
Jul 21, 2024
exileum
approved these changes
Sep 1, 2024
|
@nmfretz, can it be merged for the next OS release? |
lukechilds
force-pushed
the
master
branch
2 times, most recently
from
81f82e7 to
2694b7f
Compare
|
please merge umbrel devs |
|
Not supporting https is major security weakness. Fix this ASAP! This should have been fixed years ago, or have been part of the initial release. In fact, if I knew there was not https support, I might not have bought an Umbrel home since it does not provide the level of security that I expect my devices to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a compatibility issue with HTTPS when using the Cloudflare Tunnel to expose the Umbrel instance. The issue occurred because axios was configured with a fixed HTTP protocol. By modifying the configuration to use the protocol defined in the APP_PROTOCOL constant, all requests are now correctly made with HTTP or HTTPS as configured, preventing the browser from blocking requests when HTTPS is in use.