Skip to content

Refactor: check against the installed apps #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: check against the installed apps #1987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/ui/src/modules/desktop/uninstall-confirmation-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {useAllAvailableApps} from '@/providers/available-apps'
import { useUserApp } from '@/providers/apps'
import {
AlertDialog,
AlertDialogAction,
Expand All @@ -22,14 +22,10 @@ export function UninstallConfirmationDialog({
onOpenChange: (open: boolean) => void
onConfirm: () => void
}) {
const {appsKeyed, isLoading} = useAllAvailableApps()
const app = appsKeyed?.[appId]
const {app, isLoading} = useUserApp(appId)

if (isLoading) return null
// The app may have been removed from the app store
// so we just allow to continue uninstallation
// TODO: refactor to check for the app against the
// installed apps instead of apps in the app store

if (!app) {
console.error(`${appId} not found`)
}
Expand Down