Implementing Encoder Begin Callback for golang binding #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in EncoderBeginCallback to the Context's Process callback. This optional callback function returns false if computation should be aborted.
|
Could you help fixing the Go CI? |
Updating the default parameters to match the C++ binary's parameters. This includes: - updating the strategy to SAMPLING_BEAM_SEARCH - greedy.best_of (previously -1) - thold_pt (previously .01) - thold_ptsum (previously .01)
ggerganov
approved these changes
Sep 24, 2024
Adding in a function, GetDetectedLanguage, which will retrieve the detected language, if available.
|
Are you alright if I close this PR and open a separate that just contains the Encoder Begin Callback commit? I forgot about this PR and put a slew of other commits on the same branch, ruining this PR, then noticed it was failing because of a test file that needed updating. master...aderbedr:whisper.cpp:feat/encoderBeginCallback2 would be the branch just for this change. |
|
Yes, feel free to open a new PR with just the callback change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in EncoderBeginCallback to the Context's Process callback. This optional callback function returns false if computation should be aborted.