Skip to content

Conversation

ggerganov
Copy link
Member

No description provided.

smeso and others added 7 commits September 2, 2024 10:39
…/934)

* ggml_cont: fix issue with transposed tensors when one dimension is 1

when using multiple threads, it is not enough
to check for the tensors to be contiguous for
ggml_compute_forward_dup_same_cont to work correctly.
The tensors strides also need to match.

Signed-off-by: Salvatore Mesoraca <[email protected]>

* Add ggml_cont tests

Signed-off-by: Salvatore Mesoraca <[email protected]>

* Remove dead code

it isn't possible to reach this code because
all these functions are invoked by ggml_compute_forward_dup
if and only if src0->type != dst->type

Signed-off-by: Salvatore Mesoraca <[email protected]>

* Make ggml_compute_forward_dup_same_cont work with contiguous tensors

Co-authored-by: Georgi Gerganov <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>

---------

Signed-off-by: Salvatore Mesoraca <[email protected]>
Co-authored-by: Georgi Gerganov <[email protected]>
@ggerganov ggerganov merged commit 5236f02 into master Sep 2, 2024
90 checks passed
@ggerganov ggerganov deleted the sync branch September 2, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants