Skip to content

Conversation

iamcgn
Copy link
Contributor

@iamcgn iamcgn commented Jan 14, 2025

This PR updates the whisper.objc Xcode project so that it compiles. The project referenced 2 files that had been renamed and was missing references to ggml-cpu-traits.c and ggml-cpu-traits.h. I also had to explicitly add the -x c++ flag to convince Xcode to compile ggml-cpu-aarch64.cpp as C++ rather than C. I tested these changes in Xcode 16.2.

@ggerganov
Copy link
Member

Thanks! Let's re-enable the whisper.objc build in the CI to make sure it works now. Just uncomment these:

https://github.com/ggerganov/whisper.cpp/blob/b82d3052822af0b781ae1238d65c139806f0cd98/.github/workflows/build.yml#L679-L682

@toxtesters
Copy link

Beautiful, thank you for fixing this so quickly!

Just FYI the SwiftUI example was also broken when I tried it, not sure if it's for the same reason though. I didn't investigate very deeply.

@ggerganov
Copy link
Member

The CI encounters a code signing error:

https://github.com/ggerganov/whisper.cpp/actions/runs/12779469282/job/35634823346?pr=2736#step:6:175

I think we need to add CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= to the build.

@iamcgn
Copy link
Contributor Author

iamcgn commented Jan 16, 2025

Alright, I disabled code signing and got the build working locally. Hopefully it works in CI!

@ggerganov I also fixed the SwiftUI example. Would you prefer I open a separate PR for that or just add it here? It's just updating Package.swift to reflect the recent changes.

@ggerganov
Copy link
Member

Great! Let's make the SwiftUI changes in another PR. I will merge this one as soon as the CI is green.

@ggerganov
Copy link
Member

After the recent ggml sync (#2737), there are now a couple of new files (gguf.h/gguf.cpp) that have to be added to the projects:

https://github.com/ggerganov/whisper.cpp/actions/runs/12801432106/job/35705816929?pr=2736#step:6:320

@ggerganov ggerganov merged commit 7a423f1 into ggml-org:master Jan 18, 2025
43 checks passed
@ggerganov
Copy link
Member

@iamcgn Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants