Skip to content

support progress_callback API for addon.node #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

support progress_callback API for addon.node #2941

merged 4 commits into from
Mar 28, 2025

Conversation

buxuku
Copy link
Contributor

@buxuku buxuku commented Mar 25, 2025

feat

  • Support Inside nodejs, the compiled addon.node file provides the progress_callback API for easy tracking of processing progress
image

fix

  • In the unit test, the max_len parameter is missing, causing the unit test to fail

danbev
danbev approved these changes Mar 26, 2025
View reviewed changes
linxiaodong added 2 commits March 26, 2025 15:39
style: Format the code to improve readability
e737515 
Unified code indentation ensures consistent coding style, enhancing code readability and maintainability.
feat: support prompt api
b0b0f80
@danbev danbev merged commit 1279f0d into ggml-org:master Mar 28, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buxuku @danbev