Skip to content

Conversation

glaszig
Copy link
Contributor

@glaszig glaszig commented Jun 16, 2025

i'm on 12.7 and [MLModel predictionFromFeatures:] versions with completion handler are only available on macos 14 which is a little too cutting edge for me.

before this i'd get:

whisper-encoder-impl.m:183:17: error: no visible @interface for 'MLModel'
declares the selector 'predictionFromFeatures:completionHandler:'
    [self.model predictionFromFeatures:input completionHandler:^(id<MLFeatureProvider> prediction, NSError *predictionError) {
     ~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@glaszig
Copy link
Contributor Author

glaszig commented Jun 20, 2025

done.

@glaszig
Copy link
Contributor Author

glaszig commented Jun 24, 2025

done. also squashed commits.

@glaszig
Copy link
Contributor Author

glaszig commented Jun 24, 2025

oops. fixed.

@danbev danbev merged commit 0083335 into ggml-org:master Jun 24, 2025
54 checks passed
bygreencn added a commit to bygreencn/whisper.cpp that referenced this pull request Jun 29, 2025
* ggerganov/master: (72 commits)
  ci : use selective copy for musa image (ggml-org#3296)
  ci: set fail-fast to false in docker.yml (ggml-org#3294)
  ruby : add Whisper::VERSION (ggml-org#3292)
  whisper : add version function (ggml-org#3289)
  ci : add should_release variable (ggml-org#3288)
  docs : add cmake "-j" flag in README.md (ggml-org#3284)
  ci : add support for tag-based releases (ggml-org#3287)
  release : v1.7.6
  bench : update benches
  bench : print system info before ctx check
  stream : add nullptr check of whisper_context (ggml-org#3283)
  ci : enable main-cuda build (ggml-org#3282)
  bindings.java : update java example (ggml-org#3281)
  coreml : backport CoreML features to macos < 14 (ggml-org#3255)
  ci : reduce musa image size (ggml-org#3277)
  whisper : add .gitignore entries for OpenVINO support (ggml-org#3276)
  command: output commands to text file (ggml-org#3273)
  ci : add apt-get clean to musa Dockerfile (ggml-org#3275)
  ruby : specify Apple frameworks explicitly on build (ggml-org#3270)
  talk-llama : sync llama.cpp
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants