Skip to content

Fetch dvm git data with --all option #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Fetch dvm git data with --all option #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
743d199
Fetch dvm git data with --all options
ghosind Apr 23, 2025
76fbcdd
Pull git data with --tags
ghosind Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions dvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,13 +1974,15 @@ export DVM_VERSION="v0.10.0"
fi

# reset changes if exists
git reset --hard HEAD
git fetch
git checkout "$DVM_LATEST_VERSION"

dvm_print "DVM has upgrade to latest version, please restart your terminal or run \`source $DVM_PROFILE_FILE\` to apply changes."
if git reset --hard HEAD && git fetch --all && git pull origin master --tag && git checkout "$DVM_LATEST_VERSION"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the fetch --all is necessary

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch --all should be enough for this problem, and I keep pull --tags to double check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch to fetch is not in a global variable?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is in the global variable DVM_LATEST_VERSION

then
dvm_print "DVM has upgrade to latest version, please restart your terminal or run \`source $DVM_PROFILE_FILE\` to apply changes."

cd "$cwd" || dvm_failure
cd "$cwd" || dvm_failure
else
dvm_print_error "failed to update dvm."
cd "$cwd" && dvm_failure
fi
}
}

Expand Down